Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraction can not complete (stuck on Ready Player One) #66

Closed
CatHerderCam opened this issue Oct 18, 2021 · 6 comments
Closed

Extraction can not complete (stuck on Ready Player One) #66

CatHerderCam opened this issue Oct 18, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@CatHerderCam
Copy link

bug for Audible Library Extractor v0.2.6 public release.

Over the past few weeks, I have not been able to finish an extraction. It seams that it is hanging on "fetching additional data from store pages..." explicetly on Ready Player One. Looking at the console the only things I see is the errors listed below, and they seem to happen on every call, not just this one book.

audible-library-extractor-content-script.js:2 TypeError: Cannot read properties of null (reading 'getAttribute')
    at audible-library-extractor-content-script.js:2
    at NodeList.forEach (<anonymous>)
    at a.getDataFromCarousel (audible-library-extractor-content-script.js:2)
    at audible-library-extractor-content-script.js:2
    at Object.step (audible-library-extractor-content-script.js:2)
    at audible-library-extractor-content-script.js:2
audible-library-extractor-content-script.js:2 axios caught an error TypeError: Cannot read properties of null (reading 'getAttribute')
    at audible-library-extractor-content-script.js:2
    at NodeList.forEach (<anonymous>)
    at a.getDataFromCarousel (audible-library-extractor-content-script.js:2)
    at audible-library-extractor-content-script.js:2
    at Object.step (audible-library-extractor-content-script.js:2)
    at audible-library-extractor-content-script.js:2

Image of the screen when it hangs up:

image

And the only other notice I see is
launch-3111109c87da.min.js:29 🚀 _satellite.notify is deprecated. Please use the `_satellite.logger` API.
But this seems to be a Audible SEO issue not one with the plug in.

My thoughts are that it is the video on that page that might be causing the issue, but I am unsure on exactly how the extrntion operates to say that for sure that the video is the issue.
Link to page as per Curl
https://www.audible.com/pd/Ready-Player-One-Audiobook/B005FRGT44

Things atempted to resolve issue on my side

  • Clear Browser Cache
  • Clear DNS Cache
  • Use in Incognito mode
  • Uninstall and Reistall
  • Install in another chrome session

Atached is the console log from chrome of one atempted run.

www.audible.com-1634580026467.log

Please let me know if you need me to run anything to get you more info if you are not able to repoduce it.

@joonaspaakko
Copy link
Owner

joonaspaakko commented Oct 18, 2021

Looking at the log, I'm pretty sure I happened to fix this yesterday (sunday) in the v.0.2.7 draft (975656e). I'm not sure but I think something changed in Audible somewhat recently that caused this issue. In general this upcoming version has better error handling in the extraction process.

I waited until fixing a few obvious bugs to reply to you. Would you mind trying the newest draft? It may have it's own set of bugs though. My to-do list doesn't have any major bugs, but even today I added like 7 new ones, so there's that, but it is fairly stable.

The installation instructions are the same as for the dev releases, except you can download the current draft here ⬇️. You should be able to download it by clicking the filename and then the download button on the right. And disable any current installs of the extension.

I'm hoping to release this v.0.2.7 before the end of the month. I definitely should've had various bug fixes after v.0.2.6 but I ended up pushing it till later and later by adding new things that took way longer to figure out than I originally thought.

@joonaspaakko
Copy link
Owner

joonaspaakko commented Oct 18, 2021

I realized that I forgot to add a fail safe in that fix... Which would basically check if the cover image exists and then try to fetch the url from it using that getAttribute. Right now it just fetches the image more reliably.

Another thing added to my to-do list. (done)

@joonaspaakko joonaspaakko added the bug Something isn't working label Oct 19, 2021
@joonaspaakko
Copy link
Owner

joonaspaakko commented Oct 19, 2021

So while I think it was already fixed in that prior commit, I've now (6555d23) improved it so it should never stop the extraction process by accident. Of course, that doesn't mean something else won't.

Also, I kinda mentioned it already, but since v.0.2.6 I've added better error handling in certain places during the extraction, which alone should already get around issues where the extraction process would stop when it hits an error. So with that in mind, any fixes relating to this specific error were probably unnecessary in order to get through the extraction but help get as much data in as possible (especially with the improvements I just added), whereas an error would more than likely drop out a whole lot of potential data.

@CatHerderCam, I've also updated the dist-zip. I'd like you to try it to see if that fixes the issue.

@CatHerderCam
Copy link
Author

Can do, I've been at several conferences the past week, but as soon as I get a few I will test it.

@CatHerderCam
Copy link
Author

Looks like it works in this build, also it is blazing fast, great optimisation job.

@joonaspaakko
Copy link
Owner

Great! I'm going to close this post, but you can still comment to it if needed.

Since this is essentially a beta version that I had you install, you should know that there's now data import & export, so when the stable release comes out, you can import your data without having to do a full extraction... and I don't think I'll be changing anything in the data structure that would require a full extraction going from the beta to stable v.0.2.7.

Also, starting from this version you can right-click on any page to open a context menu that lets you jump straight to the gallery or to your audible library.


As an extra thing, I thought I'd also tell you about the wallpaper creator, which you can find by navigating to any page in the gallery with books and click the icon at the top right corner of the navigation bar:

Right now the icon hides when the editor can't be opened, but I'm planning to make it so it only gets a little dimmer and won't be clickable, so it's more obvious that it's a thing that exists, even if it can't be opened right now.

ale-wallpaper-creator

@joonaspaakko joonaspaakko pinned this issue Nov 1, 2021
@joonaspaakko joonaspaakko unpinned this issue Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants