Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Sensor class refactor #129

Open
jontofront opened this issue Dec 16, 2024 · 0 comments
Open

[Feat]: Sensor class refactor #129

jontofront opened this issue Dec 16, 2024 · 0 comments
Assignees
@jontofront
Labels
feature Sensor This doesn't seem right

Comments

@jontofront
Copy link
Owner

The request

  1. Eliminate Redundancy in Entity Creation (imilar logic is repeated across create_controller_sensors, create_mixer_sensors, and create_lambda_sensors
  2. Reduce Boilerplate in Entity Description Creation
  3. Optimize async_setup_entry function can be made cleaner by grouping entity creation
  entities = (
        create_controller_sensors(coordinator, api)
        + create_mixer_sensors(coordinator, api)
        + create_lambda_sensors(coordinator, api)
    ))

Additional information

No response
@jontofront jontofront self-assigned this Dec 16, 2024
@jontofront jontofront added the Sensor This doesn't seem right label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jontofront jontofront

Labels
feature Sensor This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

129-feat-sensor-class-refactor jontofront/ecoNET-300-Home-Assistant-Integration
1 participant
@jontofront