Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks in Node 10.x #28

Closed
rijkvanzanten opened this issue Apr 30, 2018 · 7 comments
Closed

Breaks in Node 10.x #28

rijkvanzanten opened this issue Apr 30, 2018 · 7 comments

Comments

@rijkvanzanten
Copy link

When using Node 10, the plugin creates new files in the right place, but doesn't copy over the file contents

@doowb
Copy link
Collaborator

doowb commented Apr 30, 2018

@rijkvanzanten can you post the code used to reproduce this and which operating system you're using?

@rijkvanzanten
Copy link
Author

I'm using an NPM script called copy:

copy \"./{interfaces,pages,listings}/**/meta.json\" dist which copies over all meta.json files from those three folders into dist (while keeping the directory structure intact.

I'm using macOS High Sierra 10.13.3

@doowb
Copy link
Collaborator

doowb commented Apr 30, 2018

I'm able to verify that something changed between node v9.11.1 and v10.0.0 but I haven't dug in to figure out the difference yet.

@Elephant-Vessel
Copy link

Same here, using win 7.

@tmcw
Copy link

tmcw commented May 14, 2018

Looks like the same issue as in cp-file: here's the PR that fixed that project sindresorhus/copy-file#26 - the gist is that you'll need to switch from .on('readable' to .once('readable'.

@doowb
Copy link
Collaborator

doowb commented May 14, 2018

Thanks @tmcw!

@doowb doowb closed this as completed in 5697d8e May 14, 2018
@doowb
Copy link
Collaborator

doowb commented May 14, 2018

Published a bug fix as patch 0.3.2. I checked different versions of node before publishing (and travis will also do the check) and everything works back to node@0.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants