Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji's for the log levels DEBUG, FINE, FINER and FINEST #665

Closed
twentyTwo opened this issue Apr 10, 2024 · 8 comments · Fixed by #672
Closed

Add emoji's for the log levels DEBUG, FINE, FINER and FINEST #665

twentyTwo opened this issue Apr 10, 2024 · 8 comments · Fixed by #672
Assignees
Labels
Layer: Log Management Items related to the custom objects & Logger Console app Type: Enhancement New feature or request

Comments

@twentyTwo
Copy link
Contributor

twentyTwo commented Apr 10, 2024

New Feature Summary

Emoji's are missing for the log level DEBUG, FINE, FINER, FINEST.
image

I'd like to add emoji's for the log level's that are missing. My proposed emoji's are

DEBUG - 🐞
FINE - 😊
FINER - 😄
FINEST - 😁

Let me know, if I can create a pull requests.

@twentyTwo twentyTwo added the Type: Enhancement New feature or request label Apr 10, 2024
@jongpie
Copy link
Owner

jongpie commented Apr 16, 2024

Hi @twentyTwo, thanks for the feedback! I like the idea of using distinct emojis for DEBUG, FINE, FINER, and FINEST. From an accessibility perspective, I wonder if it would be better to use emojis for FINE, FINER, and FINEST that have different shapes - I worry that the 3 smiley emojis are too similar and it'll be hard to easily distinguish between them.

What do you think about using something like these options? They're visually distinct from one another, which would make it easier to notice the differences when looking through a long list of entries.

  • DEBUG: 🐞
  • FINE: 🎯
  • FINER: 🌟
  • FINEST: 🔍

I'm definitely open to other options too, but I'd like there to be some visual variety if possible.

@jongpie jongpie added the Layer: Log Management Items related to the custom objects & Logger Console app label Apr 16, 2024
@twentyTwo
Copy link
Contributor Author

@jongpie

FINE:👍
FINER:👌
FINEST:🌟

There's a clear progression from "good" (Thumbs Up) to "better" (OK Hand) to "best" (Glowing Star), effectively conveying the intended meaning. The shapes are also different and can be easily distinguishable. What do you think?

@jongpie
Copy link
Owner

jongpie commented Apr 16, 2024

Ooooooh yeah, I love those options! The progression makes sense, and they're visually distinct.

If you're interested in submitting a PR for this change, feel free to do so & I can review - I'm also happy to make the changes later this week if you'd like, just let me know what you prefer.

@PawelWozniak
Copy link

Nice idea:
My proposition is:
INFO📢
ERROR⛔
WARN⚠️
DEBUG🐞
for FINE, FINER and FINEST I like the proposition of @twentyTwo

@jongpie
Copy link
Owner

jongpie commented Apr 17, 2024

@PawelWozniak thanks for the feedback! For INFO, I think the 📢 emoji might not be the best option - to me, that emoji indicates an announcement or that there's something urgent, which isn't really the case for an INFO log entry. Right now, INFO uses ✅ - I lean towards either keeping the existing emoji, or switching to something like ℹ️.

Let me know what you think!

@twentyTwo
Copy link
Contributor Author

@jongpie , @PawelWozniak
I think, ℹ️ is better suitable for INFO.

@jongpie
Copy link
Owner

jongpie commented Apr 18, 2024

These changes have been released in v4.13.9 🥳

@PawelWozniak
Copy link

@jongpie @twentyTwo I am using that in my debug logs as for me it is like announcement but I agree with you, maybe for wider public "i" is better. There is another UTF-8 char that can be used --> 🛈
Here is a nice page where you can search UTF-8 characters by name https://www.compart.com/en/unicode/search?q=info#characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Log Management Items related to the custom objects & Logger Console app Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants