-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emoji's for the log levels DEBUG, FINE, FINER and FINEST #665
Comments
Hi @twentyTwo, thanks for the feedback! I like the idea of using distinct emojis for DEBUG, FINE, FINER, and FINEST. From an accessibility perspective, I wonder if it would be better to use emojis for FINE, FINER, and FINEST that have different shapes - I worry that the 3 smiley emojis are too similar and it'll be hard to easily distinguish between them. What do you think about using something like these options? They're visually distinct from one another, which would make it easier to notice the differences when looking through a long list of entries.
I'm definitely open to other options too, but I'd like there to be some visual variety if possible. |
FINE:👍 There's a clear progression from "good" (Thumbs Up) to "better" (OK Hand) to "best" (Glowing Star), effectively conveying the intended meaning. The shapes are also different and can be easily distinguishable. What do you think? |
Ooooooh yeah, I love those options! The progression makes sense, and they're visually distinct. If you're interested in submitting a PR for this change, feel free to do so & I can review - I'm also happy to make the changes later this week if you'd like, just let me know what you prefer. |
Nice idea: |
@PawelWozniak thanks for the feedback! For INFO, I think the 📢 emoji might not be the best option - to me, that emoji indicates an announcement or that there's something urgent, which isn't really the case for an INFO log entry. Right now, INFO uses ✅ - I lean towards either keeping the existing emoji, or switching to something like ℹ️. Let me know what you think! |
@jongpie , @PawelWozniak |
These changes have been released in |
@jongpie @twentyTwo I am using that in my debug logs as for me it is like announcement but I agree with you, maybe for wider public "i" is better. There is another UTF-8 char that can be used --> 🛈 |
New Feature Summary
Emoji's are missing for the log level DEBUG, FINE, FINER, FINEST.
I'd like to add emoji's for the log level's that are missing. My proposed emoji's are
DEBUG - 🐞
FINE - 😊
FINER - 😄
FINEST - 😁
Let me know, if I can create a pull requests.
The text was updated successfully, but these errors were encountered: