From ffd33ed1323b98280a8e90d72384ab06074c238a Mon Sep 17 00:00:00 2001 From: Jonathan Peppers Date: Mon, 11 Mar 2024 15:02:09 -0500 Subject: [PATCH] One less IL2068 suppression --- src/Mono.Android/Java.Interop/JavaConvert.cs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Mono.Android/Java.Interop/JavaConvert.cs b/src/Mono.Android/Java.Interop/JavaConvert.cs index f4630ac54c5..a5899881761 100644 --- a/src/Mono.Android/Java.Interop/JavaConvert.cs +++ b/src/Mono.Android/Java.Interop/JavaConvert.cs @@ -57,11 +57,13 @@ static class JavaConvert { static Func? GetJniHandleConverter (Type? target) { - const string justification = "JavaDictionary<,>, JavaList<>, and JavaCollection<> use DynamicallyAccessedMembers for PublicMethods to preserve FromJniHandle()."; - [UnconditionalSuppressMessage ("Trimming", "IL2055", Justification = justification)] - [UnconditionalSuppressMessage ("Trimming", "IL2068", Justification = justification)] + [UnconditionalSuppressMessage ("Trimming", "IL2055", Justification = "JavaDictionary<,>, JavaList<>, and JavaCollection<> are preserved by the MarkJavaObjects linker step.")] [return: DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] - static Type MakeGenericType (Type type, params Type [] typeArguments) => + static Type MakeGenericType ( + [DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods)] + Type type, + params Type [] typeArguments + ) => // FIXME: https://github.com/xamarin/xamarin-android/issues/8724 // IL3050 disabled in source: if someone uses NativeAOT, they will get the warning. #pragma warning disable IL3050