Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wrong-arity linter slightly #124

Closed
jafingerhut opened this issue Dec 9, 2014 · 3 comments
Closed

Improve wrong-arity linter slightly #124

jafingerhut opened this issue Dec 9, 2014 · 3 comments

Comments

@jafingerhut
Copy link
Collaborator

Right now t.a(.j) libs always use :arglists of a function to check whether there is a call with incorrect arity.

In very recent work on Eastwood I have added a filter that suppresses such warnings if the call has an allowed number of args according to a different set of arglists in Eastwood's configuration.

That is good for suppressing wrong warnings, but it is bad in that it will never catch some calls with wrong arities, because they have allowed arities according to the :arglists contents. It would be best if t.a(.j) used the same arglists that Eastwood does elsewhere.

@jafingerhut
Copy link
Collaborator Author

Perhaps more appropriate would be for Eastwood to ignore the :maybe-arity-mismatch key in the ASTs produced by t.a(.j), and implement its own independent check for all :op :invoke ASTs.

@jafingerhut jafingerhut changed the title Make t.a(.j) libs use Eastwood-supplied arglists for :maybe-arity-mismatch tagging Improve wrong-arity linter slightly Dec 12, 2014
@jafingerhut
Copy link
Collaborator Author

Done with this commit: d803a17

@jafingerhut
Copy link
Collaborator Author

Part of Eastwood release 0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant