Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suspicious-test warnings in namespace clojure.data.avl-test that should be suppressable #117

Closed
jafingerhut opened this issue Dec 4, 2014 · 1 comment

Comments

@jafingerhut
Copy link
Collaborator

Example:

src/test/clojure/clojure/data/avl_test.clj:56:6: suspicious-test: 'is' form has non-string as second arg. The second arg is an optional message to print if the test fails, not a test expression, and will never cause your test to fail unless it throws an exception. If the second arg is an expression that evaluates to a string during test time, and you intended this, then ignore this warning.

where the second arg to the (is ...) form is the symbol msg, which is a local let binding to the return valu of a (format ...) call, which is type-hinted with a ^String return type on the arg vector. tools.analyzer(.jvm) probably provides enough info to determine that this should not be warned about, if Eastwood is modified to take advantage of it.

@jafingerhut
Copy link
Collaborator Author

Part of Eastwood release 0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant