A suspicious memory leak error occured in tig/src/argv.c.

[QiAnXinCodeSafe]

This is 360 CodeSafe Team, we found a suspicious memory leak occured in tig/src/argv.c. See

tig/src/argv.c

Line 182 in f49fc7c

env = strdup(env);

, strdup(env) will allocate memory and assign the memory adderss to env, however there is no free() action on env. So memory leak will occur at the end of function argv_from_env().

	if (env && *env)
		env = strdup(env);
	return !env || argv_from_string(argv, &argc, env);

Since I'm unfamiliar with tig, please forgive me if there is anything
wrong with my description.

Qihoo360 CodeSafe Team

[ideal]

Seems that need to be freed after call of argv_from_string().

[QiAnXinCodeSafe]

@ideal if I didn't miss something, I also think it deserve a fix. I don't know if jonas was intentionally designed to do this, or just ignored the memory release action.

[jonas]

The method is used in one place and should not be freed. It would probably be better to just inline the code.

[QiAnXinCodeSafe]

Hmm, I see. Thank you for your explanation, jonas, it seems that there will be no practical impact.