Controller macro code generation ignores traits

[dejvid]

Hi I've noticed that macro for controller code generation does not generate defs and vars defined in trait. Below are two samples. After clicking button in example 1 nothing happens, but in example 2 TODO: refresh maps is printed in console. Would be possible to extend controller code generation to traits defs and vars, this would be really helpful or are there some annotations to accomplish that.

Example code 1:

trait  CommonView {
  var currentView = "map"
  def refreshMaps() = println("TODO: refresh maps")
}

class UserDetailsCtrl ($location: Location, $scope: Scope) extends Controller with CommonView {
  currentView = "map"
}

HTML:

<div ng-controller="UserDetailsCtrl as ctl">
  {{ctl.currentView}}
 <button ng-click="ctl.refreshMaps()">Refresh</button>
</div>

Example 1 debug macro code generation output:

[info] {
[info]   import scala.scalajs.js;
[info]   import js.Dynamic.{global, literal};
[info]   module.self.controller("UserDetailsCtrl", js.Array[Any]("$location", "$scope", ((((scope: js.Dynamic, x$macro$12: biz.enef.angulate.core.Location, x$macro$13: biz.enef.angulate.Scope) => {
[info]     val ctrl = new client.angular.UserDetailsCtrl(x$macro$12, x$macro$13);
[info]     global.console.debug("Created Controller ".+("UserDetailsCtrl"), ctrl.asInstanceOf[js.Dynamic], "with scope:", scope);
[info]     scope
[info]   })): js.ThisFunction)))
[info] }
[info]       
[info]     module.controllerOf[UserDetailsCtrl]("UserDetailsCtrl")
[info] 

Example code 2:

trait  CommonView {
  var currentView = "map"
}

class UserDetailsCtrl ($location: Location, $scope: Scope) extends Controller with CommonView {
  currentView = "map"
 def refreshMaps() = println("TODO: refresh maps")
}

HTML:

<div ng-controller="UserDetailsCtrl as ctl">
  {{ctl.currentView}}
 <button ng-click="ctl.refreshMaps()">Refresh</button>
</div>

Example 2 debug macro code generation output:

[info] {
[info]   import scala.scalajs.js;
[info]   import js.Dynamic.{global, literal};
[info]   module.self.controller("UserDetailsCtrl", js.Array[Any]("$location", "$scope", ((((scope: js.Dynamic, x$macro$16: biz.enef.angulate.core.Location, x$macro$17: biz.enef.angulate.Scope) => {
[info]     val ctrl = new client.angular.UserDetailsCtrl(x$macro$16, x$macro$17);
[info]     {
[info]       global.Object.defineProperty(scope, "refreshMaps", literal(value = (() => ctrl.refreshMaps())));
[info]       global.console.debug("Created Controller ".+("UserDetailsCtrl"), ctrl.asInstanceOf[js.Dynamic], "with scope:", scope)
[info]     };
[info]     scope
[info]   })): js.ThisFunction)))
[info] }
[info]       
[info]     module.controllerOf[UserDetailsCtrl]("UserDetailsCtrl")