Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Earn): validate offer minsize #745

Merged
merged 1 commit into from
May 5, 2024

Conversation

theborakompanioni
Copy link
Collaborator

Fixes #740.
However, this is a temporary fix to prevent the backend from dying.

There should be a follow-up PR that adds better explanation more prominently.
e.g. similar to the CoinjoinRequirementSummary/CoinjoinRequirementViolation alerts on "Jam" and "Send".

@theborakompanioni theborakompanioni self-assigned this Apr 29, 2024
@theborakompanioni theborakompanioni marked this pull request as ready for review April 29, 2024 11:56
@theborakompanioni theborakompanioni marked this pull request as draft April 30, 2024 08:27
@editwentyone
Copy link

any hint why the lowest is 27300 sats? but other than that, approved

@theborakompanioni theborakompanioni marked this pull request as ready for review May 5, 2024 18:32
@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented May 5, 2024

any hint why the lowest is 27300 sats? but other than that, approved

27 300 is the "dusty minsize" and apparently needed to be substracted from the minsize. I am totally sure as to why that is the case. However, the backend does not like larger values and dies a while later.

Have you reproduced the problem and verified that this PR prevents the issue yourself?

@editwentyone
Copy link

double checked, reproduced, now double approved

@theborakompanioni
Copy link
Collaborator Author

double checked, reproduced, now double approved

Thank you 🙏

@theborakompanioni theborakompanioni merged commit 7aef192 into master May 5, 2024
3 checks passed
@theborakompanioni theborakompanioni deleted the fix/740-valid-minimum-amount branch May 5, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Earn" Feature fails without explanation if "Minimum amount" size is too high
2 participants