Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate linting from Flake8 to Ruff #141

Closed
johnthagen opened this issue Nov 28, 2022 · 4 comments · Fixed by #164
Closed

Migrate linting from Flake8 to Ruff #141

johnthagen opened this issue Nov 28, 2022 · 4 comments · Fixed by #164
Assignees
@johnthagen
Labels
enhancement New feature or request

Comments

@johnthagen
Copy link
Owner

Ruff looks like a promising alternative to Flake8. At a minimum it would solve

Need to research how this interacts or also removes the need for isort.
@johnthagen johnthagen added the enhancement New feature or request label Nov 28, 2022
@johnthagen johnthagen changed the title Migrate from Flake8 to Ruff Migrate linting from Flake8 to Ruff Jan 30, 2023
@johnthagen
Copy link
Owner Author

johnthagen commented Jan 30, 2023 •
edited
Loading

Upstream blocker before I would be ready to recommend Ruff broadly:

Nice to have:

@johnthagen
Copy link
Owner Author

johnthagen commented Feb 21, 2023 •
edited
Loading

Add Ruff's badge to the README when porting to it:

[![Ruff](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/charliermarsh/ruff/main/assets/badge/v1.json)](https://github.com/charliermarsh/ruff)

Ruff

@johnthagen
Copy link
Owner Author

johnthagen commented Feb 21, 2023 •
edited
Loading

List of Ruff's lints:

@drhagen drhagen mentioned this issue Mar 31, 2023
Closed
@johnthagen
Copy link
Owner Author

As an example, here is Poetry's commit that migrated from Flake8 to Ruff:

@johnthagen johnthagen self-assigned this May 1, 2023
@johnthagen johnthagen mentioned this issue May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnthagen johnthagen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate linting from Flake8/isort to Ruff johnthagen/python-blueprint
1 participant
@johnthagen