Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript version of foliate js #27

Open
astronautfa opened this issue Jun 24, 2024 · 3 comments
Open

typescript version of foliate js #27

astronautfa opened this issue Jun 24, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@astronautfa
Copy link

is there any plans for typescript porting of foliate js?

This renderer could very well replace epub.js, but for us to really integrate it into our workflow a typescript port is needed

thanks for the great project

@johnfactotum
Copy link
Owner

Not for now. A good part of the code is written in a quite dynamic style and doesn't seem to translate easily to well typed TypeScript. Besides that, I quite like not having a build step. Perhaps one should start with creating declaration files first.

@johnfactotum johnfactotum added the enhancement New feature or request label Jun 24, 2024
@Radiergummi
Copy link

Radiergummi commented Jun 29, 2024

Hey both of you; I'm porting parts of foliate-js to a Typescript project (I'm only interested in extracting metadata from various ebook formats for now) and would be willing to contribute those migrated parts back upstream, if this helps.

@astronautfa maybe a good starting point would be type stubs for the package?

@Blquinn
Copy link

Blquinn commented Sep 7, 2024

You can also use jsdoc to add types, I just saw an article from the svelte creator about why they prefer that route.

https://devclass.com/2023/05/11/typescript-is-not-worth-it-for-developing-libraries-says-svelte-author-as-team-switches-to-javascript-and-jsdoc/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants