Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODULE_ID_VIRTUAL need start '\0' #126

Closed
yeli19950109 opened this issue Dec 6, 2023 · 3 comments · Fixed by #127
Closed

MODULE_ID_VIRTUAL need start '\0' #126

yeli19950109 opened this issue Dec 6, 2023 · 3 comments · Fixed by #127

Comments

@yeli19950109
Copy link
Contributor

MODULE_ID_VIRTUAL need start '\0' if not start will cause something wrong with import.meta.glob with ClientSideLayout on windows
@yeli19950109
Copy link
Contributor Author

@markthree

@yeli19950109 yeli19950109 mentioned this issue Dec 6, 2023
Merged
markthree added a commit that referenced this issue Dec 6, 2023
@yeli19950109 @markthree
fix(ClientSideLayout): more user-friendly virtual ID, close #126 (#127)
e3909c7 
* fix: change MODULE_IDS and MODULE_ID_VIRTUAL and add \0

* fix(ClientSideLayout): more user-friendly virtual ID

---------

Co-authored-by: markthree <1801982702@qq.com>
@JohnCampionJr
Copy link
Owner

Wow. Thank you so much for this! I found that bug yesterday in Windows and I could not for the life of me figure out how to fix it.

Is this a known thing in Vite?

@markthree
Copy link
Collaborator

Wow. Thank you so much for this! I found that bug yesterday in Windows and I could not for the life of me figure out how to fix it.

Is this a known thing in Vite?

yes，ref -> Virtual Modules Convention
Strictly speaking, it is actually a specification for rollup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@JohnCampionJr @yeli19950109 @markthree