Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"These errors should never be propagated here" #391

Closed
simbleau opened this issue Jan 1, 2024 · 1 comment · Fixed by #393
Closed

"These errors should never be propagated here" #391

simbleau opened this issue Jan 1, 2024 · 1 comment · Fixed by #393
Labels
bug Something isn't working regression wasm Only relevant for the wasm implementation

Comments

@simbleau
Copy link
Collaborator

simbleau commented Jan 1, 2024

On Web I got this error. Not sure how it slipped in or why.

It's a regression and only affects WASM.

image
@simbleau simbleau added bug Something isn't working wasm Only relevant for the wasm implementation regression labels Jan 1, 2024
This was referenced Jan 6, 2024
Closed
Merged
@simbleau
Copy link
Collaborator Author

simbleau commented Jan 7, 2024

RCA: ws_stream_meta returns Err(StreamExhausted) when a peer disconnects (easy to trigger with Ctrl+C) which didn't get reformed into a meaningful error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working regression wasm Only relevant for the wasm implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: issue 391 johanhelsing/matchbox
1 participant
@simbleau