Add exclusions #87
Closed
Add exclusions #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joh
requested changes
Feb 28, 2022
There was a problem hiding this comment.
Hi, sorry for taking so long to review this.
Thank you for this PR, code changes look good :)
Two requests:
- The command-line syntax with the
-prefix creates a conflict with command-line arguments which also start with-. With the suggested syntax, it's not possible to exclude any file whose name matches any of the allowed command-line arguments, e.g., how would you exclude a file namedvvv? I suggest adding a new argument-xfor excluding one or more files. - Your diff include quite a few unrelated formatting changes. Please don't include pure formatting changes of unrelated code.
Thank you!
|
@ocervell Do you plan to continue work on this PR? |
|
Probably not, it's been two years and I don't remember any of this :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to specify exclude paths by prefixing them with
-.Example:
Fix #16