Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect heart beats periods #60

Closed
joffrey-bion opened this issue Jun 2, 2020 · 0 comments
Closed

Incorrect heart beats periods #60

joffrey-bion opened this issue Jun 2, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@joffrey-bion
Copy link
Owner

The actual heart beats to use should take into account both the header sent in the CONNECT frame and the one received in the CONNECTED frame.
Periods should be set to the maximum between what the client can do/expects and what the server can do/expects in each direction.
@joffrey-bion joffrey-bion added the bug Something isn't working label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joffrey-bion