-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CURRENTLY BROKEN: Nissan has changed base URL #50
Comments
I am in the US and can no longer use this API, so I have no way to test this. I'd like to gather some info here:
I don't have any immediate plans to do this, but longer term I may archive the project, especially if things change more than just the URL on an occasional basis. Just FYI. |
Thanks for the quick reply!
Your library is used by the cool evcc project (https://github.com/evcc-io/evcc) and currently the Carwings implementation is broken there. evcc-io/evcc#13941 From my point of view, just line 53 needs to get edited and it would be cool, if you could do this quickly. You can test by simply accessing the old URL API call against the new API call. BTW: Would you mind if I fork your project, make the fix and evcc will use my fork in the future? I hope that things will not change more than just the URL in the future then. 😉 |
I am happy to make the fix! But I am also happy for you to fork it if you want to take that on. |
I've pushed the fix. I appreciate your instructions for testing by hitting the old vs. the new URL. |
Thank you very much for this quick fix! I was testing in my browser with the same principle to see, if the new URL does work. 😄 |
Please change base URL to https://gdcportalgw.its-mo.com/api_v230317_NE/gdc/
The text was updated successfully, but these errors were encountered: