Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURRENTLY BROKEN: Nissan has changed base URL #50

Closed
docolli opened this issue May 17, 2024 · 5 comments
Closed

CURRENTLY BROKEN: Nissan has changed base URL #50

docolli opened this issue May 17, 2024 · 5 comments

Comments

@docolli
Copy link

docolli commented May 17, 2024

Please change base URL to https://gdcportalgw.its-mo.com/api_v230317_NE/gdc/

@joeshaw
Copy link
Owner

joeshaw commented May 17, 2024

I am in the US and can no longer use this API, so I have no way to test this. I'd like to gather some info here:

  1. Do you have a reference for this URL? (Did it come from another project like pycarwings? Pulled out of the app? Or somewhere else?)
  2. What region of the world are you in?
  3. What model year and trim level do you have?

I don't have any immediate plans to do this, but longer term I may archive the project, especially if things change more than just the URL on an occasional basis. Just FYI.

@docolli
Copy link
Author

docolli commented May 17, 2024

Thanks for the quick reply!

  1. I extracted this URL from the actual NissanConnected App. I tested this URL with another Carwings implementation in FHEM and after changing the URL the script is running fine again.
  2. I am located in Europe/Germany
  3. I have a Nissan Leaf ZE1 from 2019.

Your library is used by the cool evcc project (https://github.com/evcc-io/evcc) and currently the Carwings implementation is broken there. evcc-io/evcc#13941
I guess evcc maintainer @andig already contributed to your project.

From my point of view, just line 53 needs to get edited and it would be cool, if you could do this quickly.

You can test by simply accessing the old URL API call against the new API call.
Old: https://gdcportalgw.its-mo.com/api_v200413_NE/gdc/InitialApp_v2.php
New: https://gdcportalgw.its-mo.com/api_v230317_NE/gdc/InitialApp_v2.php

BTW: Would you mind if I fork your project, make the fix and evcc will use my fork in the future? I hope that things will not change more than just the URL in the future then. 😉

@joeshaw
Copy link
Owner

joeshaw commented May 17, 2024

I am happy to make the fix! But I am also happy for you to fork it if you want to take that on.

@joeshaw
Copy link
Owner

joeshaw commented May 17, 2024

I've pushed the fix. I appreciate your instructions for testing by hitting the old vs. the new URL.

@docolli
Copy link
Author

docolli commented May 17, 2024

Thank you very much for this quick fix!

I was testing in my browser with the same principle to see, if the new URL does work. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants