Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double pipe error #60

Closed
mriglobal opened this issue Oct 29, 2019 · 5 comments
Closed

Double pipe error #60

mriglobal opened this issue Oct 29, 2019 · 5 comments

Comments

@mriglobal
Copy link

I'm not sure if this is an issue using the --platform minION or if it's a consequence of something else, but when running tb-profiler on my data, I encountered an error after bcftools view was run in a pipeline that contained a double pipe (looked like | | with no command inside).

I'm unsure if a command didn't print to the pipeline or if there's a typo because I couldn't immediately find this line in the code. I have attached the output of tbprofiler as well as the offending command run from the command line, outside of tb-profiler.

I have removed one of the two pipes from the command and it ran successfully, but I haven't been able to integrate that into tb-profiler.

tbprofiler.log.txt

@jodyphelan
Copy link
Owner

Thanks for reporting the issue. I'll look into this and get back to you asap.

Jody

@mriglobal
Copy link
Author

mriglobal commented Oct 29, 2019

It's looking to me like it's going to be in bam.py
self.mix_cmd = "| bcftools +setGT -- -t q -i 'GT=\"het\" & AD[:1]/(AD[:0]+AD[:1])<0.7' -n . |" if mixed_as_missing else ""

self.af_filter_cmd = "| bcftools view -i 'AF>%s'" % af 35 run_cmd("bcftools view %(gbcf_file)s %(mix_cmd)s %(af_filter_cmd)s | bcftools view -T ^%(del_bed)s -g miss -O b -o %(missing_bcf_file)s" % vars(self)) 36 run_cmd("bcftools view %(gbcf_file)s %(mix_cmd)s %(af_filter_cmd)s | bcftools view -g ^miss -c 1 -O b -o %(variant_bcf_file)s" % vars(self))

Because mix_cmd is called with minION data and ends with a pipe that gets immediately met with another pipe as af_filter_cmd is the next command called.

@jodyphelan
Copy link
Owner

jodyphelan commented Oct 30, 2019

Thanks! This issue (along with a few others) should be fixed with the latest commit. Please update both pathogen-profiler and tb-profiler libraries. I will release a new version on conda soon.

Jody

@nilay-p
Copy link

nilay-p commented Nov 6, 2019

Hi Jody,
I am a beginner in bioinformatics data analysis and having the same issue as mriglobal had in my analysis. As a newbie , it is difficult for me to fix the problem. I hope new version to be released soon.

@jodyphelan
Copy link
Owner

Hi @nilay-p,

The latest version on conda (v2.7.1) should have these issues fixed!

Jody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants