Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLY doesn't notice when SBCL fails into ldb #578

Open
rpgoldman opened this issue Mar 10, 2023 · 3 comments
Open

SLY doesn't notice when SBCL fails into ldb #578

rpgoldman opened this issue Mar 10, 2023 · 3 comments

Comments

@rpgoldman
Copy link
Contributor

The MREPL buffer does not get updated to reflect the fact that SBCL has crashed into the ldb. The MREPL buffer isn't updated, possibly because the inferior lisp process is still running.

This isn't meant to be a complaint and request for fix: I'm just recording this, so that someone who is interested (possibly future me) might take it up and provide a fix.

@AkashaP
Copy link

AkashaP commented Mar 18, 2023

Echoing this. One possible effect of this is if SBCL runs out of heap space. Perhaps it's explicitly that through a CFFI Malloc or something, but in my instance i did not receive a db buffer like i normally would.

@joaotavora
Copy link
Owner

In your opinions, how could SLY notice? Is there a condition signalled? If so, from what thread? Can we even do that after (or rather -- shortly before -- a drop to ldb? SLY relies on Slynk, and Slynk is written in 100% (maybe that's 99.9%) portable CL To interface with non-portable things, Slynk relies on slynk-backend.lisp. So the way to "fix" this, IMO, is for someone to design an interface SLYNK-BACKEND:MORIBUND or something like that that gives SLY a change to notice it. Else it just thinks that the inferior process is alive and well and the network connection is taking a long time to reply back. But according to Emacs's OS process-checking primitives, both things are alive and well and there's nothing to be worried about.

@joaotavora
Copy link
Owner

someone to design an interface SLYNK-BACKEND:MORIBUND or something like that that gives SLY a change to notice it.

Sorry, I didn't expand on this idea. That interface existing, someone has to provide at least one implementation for it, in this case SBCL's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants