Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Statistic date input behavior #398

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

jo-gross
Copy link
Owner

Before you mark this PR as ready, please check the following points

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I´e created all necessary migrations?
  • The format is correct (pnpm format:check, if invalid pnpm format:fix)
  • No build errors (pnpm build)
  • I´ve tested the implemented function by my own
  • Ensure the pr title fits the conventional commit standard

Describe your work, what changed

When entering 0 to the statistic page date selection, the parsing failed some times.

Affected sites (please check during review):

  • [workspaceId]/manage/statistics - Input field fixed when entering 0, fixed dark calendar icon now properly displayed in chrome

Signed-off-by: Johannes Groß <mail@gross-johannes.de>
Signed-off-by: Johannes Groß <mail@gross-johannes.de>
@jo-gross jo-gross merged commit d73904f into main Aug 26, 2024
4 checks passed
@jo-gross jo-gross deleted the fix/statistic-dateselection branch August 26, 2024 11:05
jg-semantic-release-bot bot pushed a commit that referenced this pull request Aug 26, 2024
## [1.8.2](v1.8.1...v1.8.2) (2024-08-26)

### Bug Fixes

* Calculation creation and deletion errors solved, set shopping unit preselection if only one is available  ([#399](#399)) ([5ba3e78](5ba3e78))
* Improved TagInput by disable remove with backspace ([62158d9](62158d9))
* Statistic button alignment ([12a1947](12a1947))
* Statistic date input behavior ([#398](#398)) ([d73904f](d73904f))
@jg-semantic-release-bot
Copy link

🎉 This PR is included in version 1.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant