Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin drop event is not fired when image with theme source is dropped to a target component #1384

Closed
Flaurite opened this issue Jan 24, 2023 · 1 comment
Assignees
Labels
in: ui size: M type: bug Something isn't working

Comments

@Flaurite
Copy link
Contributor

Description

See discussion in support forum: topic.

Steps to reproduce

  1. Download demo project: demo.zip

  2. Open VaadinDndScreen.

  3. Try to move image with puppy. In the console you can see that Drop Event is occurred.

  4. Try to move image with Jmix icon. No Drop Event is fired.

Technical notes

The problem does not occurs if we use URL source.

In the client-side in DropTargetExtensionConnector class in onDrop() method there is a check that does not apply Files type. It seems with new browser versions they start to add Files type to dragged image from ThemeResource, StreamResource and probably ClassPathResource and RelativePathResource (does not check).

@Flaurite
Copy link
Contributor Author

Flaurite commented Jun 28, 2023

FireFox fixed the issue in: https://bugzilla.mozilla.org/show_bug.cgi?id=1812611
Chrome still does not fire drop event for theme and stream resources.

@Flaurite Flaurite added type: bug Something isn't working and removed type: regression Regress comparing to a previous version labels Jun 28, 2023
@gorbunkov gorbunkov closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: ui size: M type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants