fix: use Mount instead of Route for SSE message handling #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies how FastMCP handles SSE message endpoints by using Starlette's
Mount
instead ofRoute
. This change follows the recommended approach from the MCP SDK team as discussed in modelcontextprotocol/python-sdk#83.Problem
When using FastMCP with SSE transport, users encounter a
TypeError: 'NoneType' object is not callable
error. This occurs because:Route
for handling SSE messagesSseServerTransport.handle_post_message
is designed as a full ASGI applicationRoute
expects handlers to return a response object, but our handler doesn'tSolution
Following the guidance from @jspahrsummers in python-sdk#83, we:
Route("/messages", endpoint=handle_messages)
withMount("/messages/", app=sse.handle_post_message)
Mount
handles the ASGI application directlyThis approach:
Changes
run_sse_async()
to useMount
instead ofRoute
Testing
Related Issues
Fixes #69