From 01434af0430096a97fd92897a50400f280137ba5 Mon Sep 17 00:00:00 2001 From: Jean-Louis Leysens Date: Wed, 16 Jun 2021 14:57:36 +0200 Subject: [PATCH] refactor to reduce size of if statement --- .../plugins/fleet/public/search_provider.ts | 21 +++++++++++-------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/x-pack/plugins/fleet/public/search_provider.ts b/x-pack/plugins/fleet/public/search_provider.ts index 7763c715b7d460..cd4ec1c29b4579 100644 --- a/x-pack/plugins/fleet/public/search_provider.ts +++ b/x-pack/plugins/fleet/public/search_provider.ts @@ -23,6 +23,17 @@ import { pagePathGetters } from './constants'; const packageType = 'package'; +const createPackages$ = () => + from(sendGetPackages()).pipe( + map(({ error, data }) => { + if (error) { + throw error; + } + return data?.response ?? []; + }), + shareReplay(1) + ); + export const createPackageSearchProvider = (core: CoreSetup): GlobalSearchResultProvider => { const coreStart$ = from(core.getStartServices()).pipe( map(([coreStart]) => coreStart), @@ -33,15 +44,7 @@ export const createPackageSearchProvider = (core: CoreSetup): GlobalSearchResult const getPackages$ = () => { if (!packages$) { - packages$ = from(sendGetPackages()).pipe( - map(({ error, data }) => { - if (error) { - throw error; - } - return data?.response ?? []; - }), - shareReplay(1) - ); + packages$ = createPackages$(); } return packages$; };