Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] statcast_batter must be passed an end datetime #255

Closed
akern40 opened this issue Mar 18, 2022 · 0 comments · Fixed by #256
Closed

[Bug] statcast_batter must be passed an end datetime #255

akern40 opened this issue Mar 18, 2022 · 0 comments · Fixed by #256

Comments

@akern40
Copy link
Contributor

akern40 commented Mar 18, 2022 •
edited
Loading

statcast_batter is designed to have optional start/end times, and the logic for handling them is in the call to sanitize_input. However, the code does not reassign the inputs after the call to sanitize_input, and the assertions end up failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fix for statcast_batter
1 participant
@akern40