Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected divergent commits #666

Closed
ilyagr opened this issue Oct 23, 2022 · 2 comments
Closed

Unexpected divergent commits #666

ilyagr opened this issue Oct 23, 2022 · 2 comments

Comments

@ilyagr
Copy link
Contributor

ilyagr commented Oct 23, 2022

I came upon an example of unexpected divergent commits as discussed in #636 (comment) when interacting with git (repository inited with --git-dir .).

Start in this repository state. At that point, running jj rebase -s b5375 -d clippy creates several divergent commits, the ones with titles "Backspace to hide history" (change 57c3), "Disable header/ui" (change efb5), and everything in between. For a few of them, that can be explained by the ig1 tag, but not for the last one.

After some git push --force, I got to this repo state, which still contains divergent commits. For instance, on my machine, the change 57c3 has two unabandoned commits, b5375 and fcb6. I'm mentioning this since sometimes git push resolves divergent commits.

@martinvonz
Copy link
Member

I think this is another incarnation of #463. I took the first of your repo states, removed .jj/repo/git_export_operation_id, ran jj describe -m foo to make sure it was recreated. The rebase command you provided then created divergent commits. I then tried the same steps with the fix for #463 (PR #701) and there were no divergent commits. There's been a lot of different bugs caused by that. It will be nice to finally have that fixed.

@ilyagr
Copy link
Contributor Author

ilyagr commented Nov 4, 2022

That's great news, thank you!

I agree this could either remove or decrease the frequency of the other problems that we were discussing, as well. Lately, most of my issues were caused (sometimes indirectly) by my attempts to deal with this sort of divergence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants