Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataset next batch issue. #1

Open
tracer9 opened this issue Sep 25, 2017 · 1 comment
Open

dataset next batch issue. #1

tracer9 opened this issue Sep 25, 2017 · 1 comment

Comments

@tracer9
Copy link

tracer9 commented Sep 25, 2017

Hi Jiyang!
I have been followed your a series of work in action detection area. Very solid work.

Thanks to open source your TURN-TAP model.

When reading your code, I found that in dataset.py, you give mini-batch by using:
image

The point is: random sample here is not a good choice. when training, some samples may be trained multiple times while others may not be trained. That's werid.

In other words, you cannot train a whole epoch.

I think pytorch's dataset wrapper would be a good choice.

@jiyanggao
Copy link
Owner

Hi, Good idea! Sorry for the late reply. I will try this idea definately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants