Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not register handler edomh:// when data path contain national letters. #312

Open
SirAdams opened this issue May 7, 2024 · 13 comments
Open

Comments

@SirAdams
Copy link

SirAdams commented May 7, 2024

When i have on my disk national letters, in utf-8, i can not register handler.
If i move folder to place without national letter then registration work.
In windows registry national letter is change to two different characters.

@jixxed
Copy link
Owner

jixxed commented May 10, 2024

Looks like the app needs to use UTF-16LE for the registry. Can add a fix for the next release, do you have an example I can use to reproduce?

@SirAdams
Copy link
Author

Yep. "Gry-Narzędzia"

@jixxed
Copy link
Owner

jixxed commented May 11, 2024

I did not have any issue with it on UTF-8 mode. added the fix nonetheless in 2.66, so let me know if it fixed your issue

@jixxed jixxed closed this as completed May 23, 2024
@SirAdams
Copy link
Author

SirAdams commented Jun 1, 2024

I apologize for not writing back sooner.

Unfortunately the problem has not been solved and I do not know why.
This is my full directory path:
"D:\Gry-Narzędzia\Elite.Dangerous.Odyssey.Materials.Helper.portable"

I misspelled because the Windows code page is Windows-1250.

Unfortunately, I do not know why, but if the program is in this location then registering the link is not possible.
I have checked the permissions of the directory, including giving a record for all, but this did not help.
At least the program says it is not registered and without that I can't link it to my account.

Maybe the procedure for checking if the link is registered is working incorrectly?

In the registry, the entry looks correct.

If I pull the program to another directory e.g:
"D:\Gry\Elite.Dangerous.Odyssey.Materials.Helper.portable"
It all works correctly.

Tested with version 2.69

@SirAdams
Copy link
Author

SirAdams commented Jun 2, 2024

Today I decided to do another test and changed the "ę" to "e" and found that I could register and unregister the program without any problems.
I also did a test with another national character and it doesn't work either. So registering and unregistering works if there are no national characters in the path.

@SirAdams
Copy link
Author

SirAdams commented Jun 2, 2024

I include log from ProcessMonitor
Logfile.zip

@jixxed
Copy link
Owner

jixxed commented Jun 2, 2024

As the registry is updated correctly, there won't be any issue there anymore. I will add some logging to the next version that will write out the registry value as the application reads it and what it expects. there may be an issue with the readout of the registry to see whether the application is registered.
I am still unable to reproduce it locally. the registry is utf-16le and code is utf-8, but for me that doesn't seem to matter, so it might be something in windows itself.

@jixxed jixxed reopened this Jun 2, 2024
@jixxed
Copy link
Owner

jixxed commented Jun 2, 2024

I do have this enabled, which might be the reason why it works for me
https://exploratory.io/note/exploratory/Enabling-UTF-8-on-Windows-hYc3yWL0

@SirAdams
Copy link
Author

SirAdams commented Jun 2, 2024

Yes, after enabling UTF-8 in Windows, the program registers correctly.

@PancakeNM
Copy link

Can't register too... Tried already everything written here but still nothing helps.
Here's support package if this helps
support.2024-08-24_13.19.25.961.zip

@jixxed
Copy link
Owner

jixxed commented Aug 24, 2024

I see the following error: java.io.IOException: Cannot run program "powershell": CreateProcess error=2, Не удается найти указанный файл

Do you have powershell installed? Should come standard with W10/W11

@SirAdams
Copy link
Author

SirAdams commented Aug 25, 2024

I think that enabling UTF-8 is not the solution to the problem because I lose national letters in other programs. Perhaps if I would have done it right after installing windows 10....
I think there is a better solution for this.
Maybe reading from windows what encoding the player has and using that data to process everything in the program?

@PancakeNM
Copy link

I see the following error: java.io.IOException: Cannot run program "powershell": CreateProcess error=2, Не удается найти указанный файл

Do you have powershell installed? Should come standard with W10/W11

Yes i have. I even tried to reinstall it just now but that didn't helped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants