Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add associated Legendre Polynomials P_l,m #7

Merged
merged 6 commits into from
Dec 21, 2021

Conversation

eschnett
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #7 (545cc09) into master (ddb00f2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          116       171   +55     
=========================================
+ Hits           116       171   +55     
Impacted Files Coverage Δ
src/LegendrePolynomials.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb00f2...545cc09. Read the comment docs.

@eschnett
Copy link
Contributor Author

The doctest failures seem to be caused by a change in the output formatting. The current documentation has Array{...,1}, whereas doctest now expects Vector{...} in many places.

Should I update this in this PR, or do you want to correct this first in an independent PR that I then merge?

@jishnub
Copy link
Owner

jishnub commented Dec 14, 2021

I'll fix it in a separate PR so that this isn't cluttered

…ls.jl into eschnett/associated

# Conflicts:
#	docs/src/index.md
@jishnub
Copy link
Owner

jishnub commented Dec 17, 2021

Thanks for this, it's a useful addition.

@jishnub
Copy link
Owner

jishnub commented Dec 20, 2021

Is this good to go? Could you bump the patch version? In that case I'll merge and tag a new version

@eschnett
Copy link
Contributor Author

Yes, this is good to go. I updated the version number.

@jishnub jishnub merged commit b45b599 into jishnub:master Dec 21, 2021
@jishnub
Copy link
Owner

jishnub commented Dec 21, 2021

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants