Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typeset flattening #674

Closed
CohenArthur opened this issue Apr 28, 2024 · 0 comments · Fixed by #677
Closed

Add typeset flattening #674

CohenArthur opened this issue Apr 28, 2024 · 0 comments · Fixed by #677
Labels
priority [high] High priority issue typechecker Issue related to typechecking in jinko

Comments

@CohenArthur
Copy link
Member

Currently type widening only works for "one level" and does not support nesting. This is a problem for the typesystem, and also prevents #673 from being merged since the expected type of arithmetic functions is float | int, which an integer literal is not directly part of.

This will require either a pass to flatten all of our multitypes or doing some recursive set checks when going through the checker pass. I think the flattening pass is easier, but it will also be more memory hungry

@CohenArthur CohenArthur added typechecker Issue related to typechecking in jinko priority [high] High priority issue labels Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority [high] High priority issue typechecker Issue related to typechecking in jinko
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant