Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove as_bool function in Instruction trait entirely #387

Closed
CohenArthur opened this issue Dec 1, 2021 · 0 comments · Fixed by #404
Closed

Remove as_bool function in Instruction trait entirely #387

CohenArthur opened this issue Dec 1, 2021 · 0 comments · Fixed by #404
Assignees
@Skallwar
Labels
good first issue Good for newcomers interpreter Issue with the jinko interpreter module

Comments

@CohenArthur
Copy link
Member

CohenArthur commented Dec 1, 2021 •
edited
Loading

Since we now have a proper typechecker, we can completely remove the method and instead force-cast the boolean instance to a JkBool when checking the condition in an IfElse block. This is quite easy to do and should remove a lot of ugly and annoying code
@CohenArthur CohenArthur added the interpreter Issue with the jinko interpreter module label Dec 1, 2021
@CohenArthur CohenArthur changed the title Remove as_bool function trait entirely Remove as_bool function in Instruction trait entirely Dec 1, 2021
@CohenArthur CohenArthur added the good first issue Good for newcomers label Dec 1, 2021
@Skallwar Skallwar self-assigned this Dec 2, 2021
@Skallwar Skallwar mentioned this issue Dec 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skallwar Skallwar

Labels
good first issue Good for newcomers interpreter Issue with the jinko interpreter module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove as_bool in Instruction trait jinko-core/jinko
2 participants
@Skallwar @CohenArthur