Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type error in recent release of @jimp/plugins #864

Closed
tyler-johnson opened this issue Mar 27, 2020 · 3 comments · Fixed by #866
Closed

type error in recent release of @jimp/plugins #864

tyler-johnson opened this issue Mar 27, 2020 · 3 comments · Fixed by #866
Labels
released This issue/pull request has been released.

Comments

@tyler-johnson
Copy link

Expected Behavior

Not have errors when building types.

Current Behavior

Building types has this error:

node_modules/jimp/node_modules/@jimp/plugins/index.d.ts(3,20): error TS2307: Cannot find module '@jimp/plugin-circle'.

node_modules/jimp/node_modules/@jimp/plugins/index.d.ts(10,21): error TS2307: Cannot find module '@jimp/plugin-fisheye'.

node_modules/jimp/node_modules/@jimp/plugins/index.d.ts(20,20): error TS2307: Cannot find module '@jimp/plugin-shadow'.

node_modules/jimp/node_modules/@jimp/plugins/index.d.ts(21,23): error TS2307: Cannot find module '@jimp/plugin-threshold'.

Failure Information (for bugs)

Looks like these dependencies are missing from package.json and are not installed.

Steps to Reproduce

Build a TypeScript file that imports Jimp.

Screenshots

Context

  • Jimp Version: 0.9.7
  • Operating System: Mac 10.15
  • Node version: Node 13.11

Failure Logs

@crutchcorn
Copy link
Member

I'll be investigating tonight. Took a quick glance at the code and can't find anything immediately obviously missing. Makes me wonder if there's a peerDep issue

@crutchcorn
Copy link
Member

Sure enough, it's a dependency issue. I'll resolve and have a PR out in no time :)

@hipstersmoothie
Copy link
Collaborator

🚀 Issue was released in v0.9.8 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants