Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow the workflow to specify the minor & patch version #168

Closed
Disservin opened this issue Oct 22, 2023 · 2 comments · Fixed by #195
Closed

feat: allow the workflow to specify the minor & patch version #168

Disservin opened this issue Oct 22, 2023 · 2 comments · Fixed by #195
Assignees

Comments

@Disservin
Copy link

Disservin commented Oct 22, 2023

Hi,

I think it would be great if the action also exposes a way to define the minor and patch version,
so that the version of clang-format is fixed.
Currently the version may change depending on what ubuntu currently distributes.
clang-format 17 uses this version right now https://packages.ubuntu.com/mantic/clang-format-17.

Edit: The action is also a bit of a blackbox, when you specify it's not clear directly which exact version was used for the format check. One needs to check the current distributed version from the link above which is a might annoying, can the workflow maybe expose the current version which is printed by clang-format --version ?

@jidicula
Copy link
Owner

Thanks for this feedback and for using my action! I want to gather some more data about this in #192, so I'd love to get your vote and an optional comment sharing more details so I can understand this problem better.

@jidicula
Copy link
Owner

jidicula commented May 19, 2024

I'm going to close this as completed with #195 and in the meantime I'll gather more data about minor+patch version specification needs in #192.

@jidicula jidicula self-assigned this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants