Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to differentiate tools with identical serial, but different part numbers #3

Open
auneri opened this issue Nov 19, 2015 · 4 comments
Labels

Comments

@auneri
Copy link
Contributor

auneri commented Nov 19, 2015

Current implementation assumes that serial numbers are unique identifiers, however the screenshot below begs to differ.

sensorsserialnumbers

@auneri auneri added the bug label Nov 19, 2015
@nargesahmidi
Copy link

thanks Ali.
Can we just modify the code in CISST NDI to not require us to specify the "Serial Number" in the XML configuration file? and instead automatically detects it from communication during the initialization procedure? like maybe while doing PHSR command.

For example, the unique pseudo-serial number inside the code can be generated using any unique ID that Aurora sends when responding to "PHSR" command.

@auneri
Copy link
Contributor Author

auneri commented Nov 19, 2015

Hm.. I'm pretty sure there is a better way to handle unique identifiers, now that we know serial number is not unique. However it may a bit involved due to how wireless tools are handled (applies to Polaris devices). I will need to have a better look, it has been a while.

If you need results fast, you may want to create a pseudo serial number, similar to what we have done for multi-channel markers. If tool part number is read (Tool.PartNumber) then you would compare part numbers when a non-unique serial number is encountered, and create a pseudo serial number accordingly.

@nargesahmidi
Copy link

thanks Ali.
My urgent question was whether there is "a" way to communicate with Aurora which is not based on the "serial number". You said yes. Now the urgency is over and I can go ahead with my conversation with NDI.

I however want this problem to get fixed. We will need the corrected code for Mid December. Can you fix the problem by then?

thanks

@auneri
Copy link
Contributor Author

auneri commented Nov 19, 2015

Let me have look first and come up with a plan. I will let you know, and will probably need help with testing anyway :)

In fact, to begin, could let me know of the output of this line to see if we are at least obtaining the unique part number in full.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants