Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light or cover groups not found #94

Open
deb42 opened this issue Mar 27, 2021 · 11 comments · Fixed by #159
Open

Light or cover groups not found #94

deb42 opened this issue Mar 27, 2021 · 11 comments · Fixed by #159

Comments

@deb42
Copy link

deb42 commented Mar 27, 2021

I cannot find the light or cover groups in Home Assistant which are created in Bush Jaeger. This feature is not stated in the discription but it would be cool to get clearification whether it's really not working or I missed some sort of configuration.

Thank you in advance!

@jheling
Copy link
Owner

jheling commented Mar 30, 2021

hello, there is no support for these groups yet. I was wondering; how would you expect these groups to appear in Home Assistant? As a single light or single cover?

@deb42
Copy link
Author

deb42 commented Apr 5, 2021

Sorry for the late response. For lights I would suggest a similar approach as the deCONZ add-on provides. There, light-groups appear as a singe light which handles all lights in this group similarly. Thus, if you turn on the group, all lights in this group are turned on. Or if you change the brightness of the group, all lights in the group get the same brightness. Covers could work the same way.

@miezie
Copy link
Contributor

miezie commented Apr 5, 2021

Why not use the group functionality that home assistant already has... that’s the way to go.

@guerda
Copy link

guerda commented Feb 13, 2023

I would like to see the groups for lights and covers as well.

Why not use the group functionality that home assistant already has... that’s the way to go.

One difference is the delay. If I define a group in HA, the free@home AP is called (at least) once for each device. If the group is addressed, this is done within ~ one call.

@guerda
Copy link

guerda commented Apr 11, 2023

I looked more into the groups. It seems that groups are defined like this in the backup:

Cover group:
<device maxAPDULength="31" iconId="4001" functionId="4001" nameId="0167" softwareId="0003" softwareVersion="0.3" deviceId="4001" deviceFlavor="00" domainAddress="BAE7" type="group" profile="0000" serialNumber="FFFF40010002" commissioningState="ready" copyId="0">

Light group:
<device maxAPDULength="31" iconId="4000" functionId="4000" nameId="0166" softwareId="0002" softwareVersion="0.2" deviceId="4000" deviceFlavor="00" domainAddress="BAE7" type="group" profile="0000" serialNumber="FFFF40000001" commissioningState="ready" copyId="0">

That means that here in this file https://github.com/jheling/freeathome/blob/master/custom_components/freeathome/fah/pfreeathome.py#L371 , the device_type group would be missing

Further more, it seems that they "feel" like a single light or cover. Would it be an idea to just add them as a single light or cover for a first try?

@Tho85
Copy link
Collaborator

Tho85 commented Apr 11, 2023

I've done a first implementation for light and dimmer groups in #159, feel free to try the code there and let me know if it works. Light groups are exported as single lights.

@guerda
Copy link

guerda commented Apr 12, 2023

I will check it out asap and give you feedback.

@guerda
Copy link

guerda commented Apr 14, 2023

I tested your branch with a light group (binary, not a dimmer) and it worked smoothly. Reloading the integration automatically detected the light groups and I was able to switch them on and off. The delay is not any different than with the free@home app.

I also tested dimming light groups and those work, too.

Great work! Looking forward for the integration!

@guerda
Copy link

guerda commented Apr 14, 2023

Thank you for merging this. It is not completely resolved as cover groups are not included yet.

@Tho85
Copy link
Collaborator

Tho85 commented Apr 14, 2023

Right, reopened until this is fixed

@Tho85 Tho85 reopened this Apr 14, 2023
@guerda
Copy link

guerda commented May 7, 2023

Hi @Tho85 !
Do you need any help with implementing the cover groups?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants