From 8de8f7099ce089e33afa9e4c3d11db9b3807fef0 Mon Sep 17 00:00:00 2001
From: mmusich <marco.musich@cern.ch>
Date: Fri, 24 Jun 2022 16:01:39 +0200
Subject: [PATCH] post-merge fixes for #38449

---
 .../python/AlcaSiPixelAliHarvesterHG_cff.py       | 15 +++++++--------
 .../src/AlignmentProducerBase.cc                  |  9 +--------
 CondFormats/PCLConfig/src/AlignPCLThresholdsHG.cc |  7 +------
 3 files changed, 9 insertions(+), 22 deletions(-)

diff --git a/Alignment/CommonAlignmentProducer/python/AlcaSiPixelAliHarvesterHG_cff.py b/Alignment/CommonAlignmentProducer/python/AlcaSiPixelAliHarvesterHG_cff.py
index 81715f051b149..a4e4bfbcd94c3 100644
--- a/Alignment/CommonAlignmentProducer/python/AlcaSiPixelAliHarvesterHG_cff.py
+++ b/Alignment/CommonAlignmentProducer/python/AlcaSiPixelAliHarvesterHG_cff.py
@@ -41,7 +41,7 @@
     pedeSteerer = dict(
         pedeCommand = 'pede',
         method = 'inversion  5  0.8',
-        options = cms.vstring(
+        options = [
             #'regularisation 1.0 0.05', # non-stated pre-sigma 50 mrad or 500 mum
             'entries 500',
             'chisqcut  30.0  4.5',
@@ -50,9 +50,9 @@
             'skipemptycons' 
             #'outlierdownweighting 3','dwfractioncut 0.1'
             #'outlierdownweighting 5','dwfractioncut 0.2'
-        ),
+        ],
         fileDir = 'HGalignment/',
-        runDir = cms.untracked.string('HGalignment/'),
+        runDir = 'HGalignment/',
         steerFile = 'pedeSteerHG',
         pedeDump = 'pedeHG.dump'
     ),
@@ -71,10 +71,9 @@
 
 from DQMServices.Core.DQMEDHarvester import DQMEDHarvester
 dqmEnvSiPixelAliHG = DQMEDHarvester('DQMHarvestingMetadata',
-                                  subSystemFolder = cms.untracked.string('AlCaReco'),  
-                                  )
+                                    subSystemFolder = cms.untracked.string('AlCaReco'))
 
 ALCAHARVESTSiPixelAliHG = cms.Sequence(SiPixelAliMilleFileExtractorHG*
-                                     SiPixelAliPedeAlignmentProducerHG*
-                                     SiPixelAliDQMModuleHG*
-                                     dqmEnvSiPixelAliHG)
+                                       SiPixelAliPedeAlignmentProducerHG*
+                                       SiPixelAliDQMModuleHG*
+                                       dqmEnvSiPixelAliHG)
diff --git a/Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc b/Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc
index 4bd4c6488a54d..6ad94af7fe247 100644
--- a/Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc
+++ b/Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc
@@ -854,14 +854,7 @@ void AlignmentProducerBase::writeForRunRange(cond::Time_t time) {
 
     auto alignments = alignableTracker_->alignments();
     auto alignmentErrors = alignableTracker_->alignmentErrors();
-    this->writeDB(
-        // ~alignments, "TrackerAlignmentRcd", alignmentErrors, "TrackerAlignmentErrorExtendedRcd", trackerGlobal, time);
-        alignments,
-        tkAliRcdName_,
-        alignmentErrors,
-        "TrackerAlignmentErrorExtendedRcd",
-        trackerGlobal,
-        time);
+    this->writeDB(alignments, tkAliRcdName_, alignmentErrors, "TrackerAlignmentErrorExtendedRcd", trackerGlobal, time);
 
     // Save surface deformations to database
     if (saveDeformationsToDB_) {
diff --git a/CondFormats/PCLConfig/src/AlignPCLThresholdsHG.cc b/CondFormats/PCLConfig/src/AlignPCLThresholdsHG.cc
index edb264fb9ec1a..7deeaeddebde7 100644
--- a/CondFormats/PCLConfig/src/AlignPCLThresholdsHG.cc
+++ b/CondFormats/PCLConfig/src/AlignPCLThresholdsHG.cc
@@ -101,12 +101,7 @@ float AlignPCLThresholdsHG::getFractionCut(const std::string &AlignableId, const
 //****************************************************************************//
 const bool AlignPCLThresholdsHG::hasFloatMap(const std::string &AlignableId) const {
   const auto &it = floatMap_.find(AlignableId);
-
-  if (it != floatMap_.end()) {
-    return true;
-  } else {
-    return false;
-  }
+  return (it != floatMap_.end());
 }
 
 //****************************************************************************//