Replies: 1 comment
-
Sure, go ahead and submit a PR! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
First of all, thanks for creating and maintaining this amazing tool! I've been using the CLI for several years and just recently have gotten into working with the library and Lua filters, and it's been such a lifesaver for my work.
Last week, as I was writing a filter for generating sidebars, it occurred to me that the Asciidoc writer currently supports fenced admonitions (notes, tips, etc.) but, from what I can tell, not sidebars, which follow a very similar pattern.
Acknowledging that sidebars (as RawBlocks) can be generated from Divs by using filters, I was wondering if it wouldn't make sense to add support for sidebars to the Asciidoc writer, to keep them on similar footing as admonitions?
I took an initial stab at modifying the writer and adding a test (the latter not shown below). It seems to work well with the handful of test cases I've thrown at it. Would something like this be considered if I were to create a PR with the change to the writer and the test?
Beta Was this translation helpful? Give feedback.
All reactions