Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default exclude / warning for ".m2" and/or "repository" #91

Closed
jschneider opened this issue Jul 7, 2018 · 3 comments
Closed

Add default exclude / warning for ".m2" and/or "repository" #91

jschneider opened this issue Jul 7, 2018 · 3 comments

Comments

@jschneider
Copy link
Contributor

I hat the issue that my build failed when using "-Dmaven.repo.local=.m2/repository".
This parameter is suggested when using docker to build.

Unfortunately jgitver modifies files stored within the repository.

Adding exclusions to the jtiver-config.xml solves this issue. But it has been very hard for me to diagnose this problem.

Could you add these default exclusions:

    <exclusion>.repository</exclusion> <!-- often used by jenkins -->
    <exclusion>target</exclusion>
    <exclusion>.m2</exclusion>
  </exclusions>

or at least add warnings when entering a directory that is called "repository"?

@McFoggy
Copy link
Contributor

McFoggy commented Jul 7, 2018

This parameter is suggested when using docker to build.

what is documented is to copy your local repository to /root/.m2 which is the default location of the maven local repository for root user. But it is a bit strange then to map/copy the project under build at the same place.
Having default directories excluded is a decision a bit difficult to take without enough background on the possible use cases.
As you noticed, even in such a bad situation, by configuration, jgitver is able to work properly. A better documentation on this point might be enough.

@jschneider
Copy link
Contributor Author

The problem is: It is very hard to identify the root problem from the given error messages.
It took me a long time to figure it out - and I know JGitver very well...

But I understand that there might be false positives.

@McFoggy
Copy link
Contributor

McFoggy commented Jul 8, 2018

with experience & the behavior described in #90, all POMs resolved with the same version as the project, it was clear that jgitver was changing the versions. It is such a behavior that needs to be better documented regarding what is occurring and how to correct it.
Honestly I think a better documentation, wiki, faq is the first thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants