Adds root directive to vhost_header and vhost_ssl_header templates.

[bradfier]

This change will result in there being a 'root' directive in both the
server block, and the location sub-block. This is a perfectly valid
configuration and avoids the possible issue of having a location
with no 'root' if it isn't explicitly set.

---

From #142, I thought this was the most concise way to solve the 'no root' issue, another possibility would be to remove the root directive from the default '/' location, but having the duplicate has no ill-effects and keeps the '/' location consistent with any others added to the vhost.

I don't like schkovich's solution (d22a259) as it removes the ability to define locations blocks with different document roots.

[jfryman]

if @www_root should be more than sufficient here, since it is undef by default. https://github.com/jfryman/puppet-nginx/blob/master/manifests/resource/vhost.pp#L121

Also, <%-?

[jfryman]

Dig it! Can you clean it up a bit? I'll get it merged in.

[bradfier]

Tidied up the two new blocks, stripped an extra newline so I can leave it without <%-, which keeps it consistent with the rest of the blocks in the template, and removed the pointless defined?.

[3flex]

should this be if @wwwroot?

[jfryman]

I believe that @www_root is right, but there absolutely needs to be an if here. Thanks for double-checking!

https://github.com/jfryman/puppet-nginx/blob/master/manifests/resource/vhost.pp#L123

@bradfirj: can you make this change really quickly? I'll get it merged in. 🍻

[bradfier]

Thanks @3flex, chucked the missing ''if'' in.

[3flex]

Also now there are tests, do you think you could add these conditions to spec/defines/resource_vhost_spec.rb? You should be able to base them on the test for the non-SSL version (see https://github.com/jfryman/puppet-nginx/blob/master/spec/defines/resource_vhost_spec.rb#L138)

[schkovich]

@bradfirj Unfortunately having root defined inside location block does have significant side effects:

[error] 2943#0: *1 FastCGI sent in stderr: "Primary script unknown" while reading response header from upstream

Please check http://linux.ioerror.us/2013/05/cant-get-php-fpm-with-nginx-to-work/

P. S. Sorry about the late reply. :) I missed your comment somehow. :(

[bradfier]

@schkovich The example you linked gives an error not because the questioner has defined a root inside a location but because they have defined it wrongly!

Consider, from the linked article/question:

location ~ .php$ {
    root           html;
    ....
    fastcgi_param  SCRIPT_FILENAME  $document_root$fastcgi_script_name;
}

The issue here is not that root has been defined inside location ~ .php$ but that it has been defined as 'html'.

Thus the SCRIPT_FILENAME passed to FastCGI will be html$scriptname, as opposed to /home/webuser1/www/public$scriptname, which is the behaviour I suspect the author was looking for.

All that said, there are a limited number of circumstances where you would want to define root inside a location block instead of using alias, however I thought it would be useful to allow the sysadmin to make their own decision on that matter.

[schkovich]

@bradfirj I am sorry I did not check the question at all but only the answer. Anyway get https://github.com/schkovich/ultramarin spin up Virtualbox and you will get the error.

Further on, I truly do not understand why an option to do something that is clearly wrong should be provided. IMHO it is way more better to prevent sysadmins from doing stupidity.

[jfryman]

@bradfirj I'm going to second the need for tests here. Also, needs another rebase. :)

@schkovich You bring up an interesting point. As far as the ability to do something wrong ... I'd rather provide sane defaults and let a user make silly decisions on their own. For the most part, our target audience is going to be sysadmins or other administrators. Those wanting to go far off the beaten path should absolutely be able to.

[jfryman]

Way old. Thanks for taking a pass at this... going to revisit when 🕐 allows. Please reopen and rebase if you wanna take another pass at this.