Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding JFrog's public GPG key to OpenTofu registry #909

Closed
StephenWithPH opened this issue Mar 14, 2024 · 10 comments
Closed

adding JFrog's public GPG key to OpenTofu registry #909

StephenWithPH opened this issue Mar 14, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request opentofu OpenTofu related topics

Comments

@StephenWithPH
Copy link

Is your feature request related to a problem? Please describe.
When trying to use terraform-provider-artifactory via OpenTofu, I receive the following error:

Installed jfrog/artifactory v10.3.1. Signature validation was skipped due to the registry not containing GPG keys for this provider

This arises because OpenTofu needs a member of JFrog's GitHub org to validate the public key used to sign provider releases.

Describe the solution you'd like
A member of JFrog's GitHub org needs to open a PR to opentofu/registry using this PR form for signing keys.

Describe alternatives you've considered
N/A

Additional context
I believe submitting the GPG will cover all of JFrog's providers.

@StephenWithPH StephenWithPH added the enhancement New feature or request label Mar 14, 2024
@alexhung
Copy link
Member

@StephenWithPH Thanks for the head up. I've added this to our sprint.

@StephenWithPH
Copy link
Author

I believe submitting the GPG will cover all of JFrog's providers.

It occurred to me that my comment makes the assumption that JFrog uses the same signing key for all five of the providers. If that's not the case, you'll need to submit the signing key for each.

@alexhung alexhung added the opentofu OpenTofu related topics label Mar 15, 2024
@alexhung
Copy link
Member

alexhung commented Mar 15, 2024

@StephenWithPH See opentofu/registry#315

@StephenWithPH
Copy link
Author

Thank you for the quick turnaround! 🎉

@alexhung
Copy link
Member

alexhung commented Mar 15, 2024

@StephenWithPH I submitted an expired public key the first time. You may see this error message Error while installing jfrog/artifactory v10.1.4: authentication signature from unknown issuer until my new PR is merged and synced at next cron job run (at top of the hour).

@StephenWithPH
Copy link
Author

StephenWithPH commented Mar 15, 2024

Got it. No worries!

@alexhung
Copy link
Member

@StephenWithPH All fixed!

Screenshot 2024-03-15 at 11 30 15 AM

@alexhung
Copy link
Member

alexhung commented Mar 18, 2024

@StephenWithPH Turns out we were using a separate (older) signing key for Artifactory provider, whereas the other providers use the same (newer) key. Terraform registry allows for multiple signing keys but OpenTofu doesn't. Thus once I uploaded the old key to OpenTofu registry, the other 4 providers were no longer installable.

I've updated this provider to be signed with the newer key as well as updating OpenTofu registry with this key, so this problem is solved. Right now we are waiting for OpenTofu registry cache to be updated before 10.3.3 is installable in OpenTofu.

@StephenWithPH
Copy link
Author

Thank you for your continued work on this. Glad to hear that the bumps are getting smoothed out. I'll keep an eye on that linked issue.

@alexhung
Copy link
Member

@StephenWithPH tofu init just now runs successfully with new key ID.

Screenshot 2024-03-18 at 11 39 12 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request opentofu OpenTofu related topics
Projects
None yet
Development

No branches or pull requests

2 participants