From 5164e3682dfb5398b2b9f63e08f6b82aba250950 Mon Sep 17 00:00:00 2001 From: Gabriel-Trintinalia Date: Fri, 1 Dec 2023 16:52:18 +1100 Subject: [PATCH] [MINOR] - Add plugin version summary (#6221) * Add plugin version to summary on startup Signed-off-by: Gabriel-Trintinalia * Remove test code Signed-off-by: Gabriel-Trintinalia --------- Signed-off-by: Gabriel-Trintinalia --- .../besu/services/BesuPluginContextImpl.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/besu/src/main/java/org/hyperledger/besu/services/BesuPluginContextImpl.java b/besu/src/main/java/org/hyperledger/besu/services/BesuPluginContextImpl.java index 184c85f45de..a35c3e0a87a 100644 --- a/besu/src/main/java/org/hyperledger/besu/services/BesuPluginContextImpl.java +++ b/besu/src/main/java/org/hyperledger/besu/services/BesuPluginContextImpl.java @@ -124,8 +124,9 @@ public void registerPlugins(final Path pluginsDir) { try { plugin.register(this); LOG.info("Registered plugin of type {}.", plugin.getClass().getName()); - lines.add(String.format(plugin.getClass().getSimpleName())); - addPluginVersion(plugin); + String pluginVersion = getPluginVersion(plugin); + pluginVersions.add(pluginVersion); + lines.add(String.format("%s (%s)", plugin.getClass().getSimpleName(), pluginVersion)); } catch (final Exception e) { LOG.error( "Error registering plugin of type " @@ -156,7 +157,7 @@ public List getPluginsSummaryLog() { return lines; } - private void addPluginVersion(final BesuPlugin plugin) { + private String getPluginVersion(final BesuPlugin plugin) { final Package pluginPackage = plugin.getClass().getPackage(); final String implTitle = Optional.ofNullable(pluginPackage.getImplementationTitle()) @@ -166,8 +167,7 @@ private void addPluginVersion(final BesuPlugin plugin) { Optional.ofNullable(pluginPackage.getImplementationVersion()) .filter(Predicate.not(String::isBlank)) .orElse(""); - final String pluginVersion = implTitle + "/v" + implVersion; - pluginVersions.add(pluginVersion); + return implTitle + "/v" + implVersion; } /** Before external services. */