Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jezek/xgbutil does not exist #2

Closed
scrouthtv opened this issue Mar 1, 2021 · 3 comments
Closed

jezek/xgbutil does not exist #2

scrouthtv opened this issue Mar 1, 2021 · 3 comments

Comments

@scrouthtv
Copy link

xgb/examples/doc.go

Lines 13 to 14 in cec22bd

a lot of boiler plate. To that end, I'd recommend use of my higher level
library, xgbutil: https://github.com/jezek/xgbutil

Hello, in the documentation at the root of the examples folder, a package named github.com/jezek/xgbutil is mentioned. However, it does not exist:

https://github.com/jezek/xgbutil

I'd recommend either reverting the link to BurntSushi/xgbutil or forking it to jezek

@jezek
Copy link
Owner

jezek commented Mar 2, 2021

Hmm... When reverting the link and someone would use BurntSushi/xgbutil in project, then he wouldn't use jezek/xgb, but BurntSushi/xgb.

3 solutions come to my mind:

  1. Change the doc link to BurntSushi with the note about dependecy.
  2. Change the doc link & fill issue (make PR) to use jezek/xgb.
  3. Keep link & fork BurntSushi/xgbutil and change dependency.

@scrouthtv Which one would you recomend or do you have another idea?

@scrouthtv
Copy link
Author

I'm in favor of 3)

As you said, xgbutil itself depends on xgb and Burnt sushi's xgbutil currently references their xgb not this one.

xgbutil seems unmaintained as well (it doesn't even have a go.mod) so forking it and reactivating would be a nice side-effect

@jezek
Copy link
Owner

jezek commented Mar 2, 2021

I've forked it and rewrote dependencies needed to pass test/compile

@jezek jezek closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants