From 2463f8c9f4891626183654f6fb4c6579e980b451 Mon Sep 17 00:00:00 2001 From: Lachlan Roberts Date: Mon, 1 May 2023 14:31:14 +1000 Subject: [PATCH 1/2] deprecate PushSessionCacheFilter Signed-off-by: Lachlan Roberts --- .../java/org/eclipse/jetty/servlets/PushSessionCacheFilter.java | 1 + 1 file changed, 1 insertion(+) diff --git a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/PushSessionCacheFilter.java b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/PushSessionCacheFilter.java index fb93cea5697b..3ed504fe19e5 100644 --- a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/PushSessionCacheFilter.java +++ b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/PushSessionCacheFilter.java @@ -37,6 +37,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +@Deprecated public class PushSessionCacheFilter implements Filter { private static final String RESPONSE_ATTR = "PushSessionCacheFilter.response"; From ce80bf46d4f9f11eee583354079138f42e4a4a33 Mon Sep 17 00:00:00 2001 From: Lachlan Roberts Date: Tue, 2 May 2023 12:02:16 +1000 Subject: [PATCH 2/2] update javadoc and add log warning message for PushSessionCacheFilter Signed-off-by: Lachlan Roberts --- .../eclipse/jetty/servlets/PushSessionCacheFilter.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/PushSessionCacheFilter.java b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/PushSessionCacheFilter.java index 3ed504fe19e5..592a4c080f42 100644 --- a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/PushSessionCacheFilter.java +++ b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/PushSessionCacheFilter.java @@ -37,6 +37,9 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +/** + * @deprecated no replacement for this deprecated http feature + */ @Deprecated public class PushSessionCacheFilter implements Filter { @@ -47,6 +50,11 @@ public class PushSessionCacheFilter implements Filter private final ConcurrentMap _cache = new ConcurrentHashMap<>(); private long _associateDelay = 5000L; + public PushSessionCacheFilter() + { + LOG.warn(PushSessionCacheFilter.class.getSimpleName() + " is an example class not suitable for production."); + } + @Override public void init(FilterConfig config) throws ServletException {