From a4dc95aa79cff9be028d46176b14c54a14f0352a Mon Sep 17 00:00:00 2001 From: Ravi Kumar Date: Thu, 17 Dec 2020 21:27:03 +0530 Subject: [PATCH 1/2] Added JMX annotations for ScheduledExecutorScheduler Signed-off-by: Ravi Kumar --- .../thread/ScheduledExecutorScheduler.java | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ScheduledExecutorScheduler.java b/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ScheduledExecutorScheduler.java index 8519e08c4644..3407310773f6 100644 --- a/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ScheduledExecutorScheduler.java +++ b/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ScheduledExecutorScheduler.java @@ -25,6 +25,8 @@ import java.util.concurrent.atomic.AtomicInteger; import org.eclipse.jetty.util.StringUtil; +import org.eclipse.jetty.util.annotation.ManagedAttribute; +import org.eclipse.jetty.util.annotation.ManagedObject; import org.eclipse.jetty.util.annotation.Name; import org.eclipse.jetty.util.component.AbstractLifeCycle; import org.eclipse.jetty.util.component.Dumpable; @@ -37,6 +39,7 @@ * queue even if the task did not fire, which provides a huge benefit in the performance * of garbage collection in young generation. */ +@ManagedObject("A scheduler") public class ScheduledExecutorScheduler extends AbstractLifeCycle implements Scheduler, Dumpable { private final String name; @@ -154,4 +157,22 @@ public boolean cancel() return scheduledFuture.cancel(false); } } + + @ManagedAttribute("name of scheduler") + public String getName() + { + return name; + } + + @ManagedAttribute("is scheduler daemon") + public boolean isDaemon() + { + return daemon; + } + + @ManagedAttribute("number of scheduler threads") + public int getThreads() + { + return threads; + } } From 433f6127935a724b341b7a575b824d426eb30e37 Mon Sep 17 00:00:00 2001 From: Ravi Kumar Date: Fri, 18 Dec 2020 08:31:04 +0530 Subject: [PATCH 2/2] Made changes as per the review comments Signed-off-by: Ravi Kumar --- .../jetty/util/thread/ScheduledExecutorScheduler.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ScheduledExecutorScheduler.java b/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ScheduledExecutorScheduler.java index 3407310773f6..931936239cb3 100644 --- a/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ScheduledExecutorScheduler.java +++ b/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ScheduledExecutorScheduler.java @@ -39,7 +39,7 @@ * queue even if the task did not fire, which provides a huge benefit in the performance * of garbage collection in young generation. */ -@ManagedObject("A scheduler") +@ManagedObject public class ScheduledExecutorScheduler extends AbstractLifeCycle implements Scheduler, Dumpable { private final String name; @@ -158,19 +158,19 @@ public boolean cancel() } } - @ManagedAttribute("name of scheduler") + @ManagedAttribute("The name of the scheduler") public String getName() { return name; } - @ManagedAttribute("is scheduler daemon") + @ManagedAttribute("Whether the scheduler uses daemon threads") public boolean isDaemon() { return daemon; } - @ManagedAttribute("number of scheduler threads") + @ManagedAttribute("The number of scheduler threads") public int getThreads() { return threads;