From 921088ac072d4144ef6684e580dabbb8188c2566 Mon Sep 17 00:00:00 2001 From: Jan Bartel Date: Mon, 4 Nov 2024 14:06:40 +1100 Subject: [PATCH] Remove old test case from HttpConnectionTest --- .../jetty/server/HttpConnectionTest.java | 22 ------------------- 1 file changed, 22 deletions(-) diff --git a/jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/HttpConnectionTest.java b/jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/HttpConnectionTest.java index ee69c824524d..c356c7199a21 100644 --- a/jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/HttpConnectionTest.java +++ b/jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/HttpConnectionTest.java @@ -53,7 +53,6 @@ import org.hamcrest.Matchers; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.Arguments; @@ -865,27 +864,6 @@ public void testBadURIencoding() throws Exception checkContains(response, 0, "HTTP/1.1 400"); } - @Test - @Disabled("review this test. seems a security issue to fallback from utf-8 to iso-1, was there a reason to do that?") - public void testBadUTF8FallsbackTo8859() throws Exception - { - _server.start(); - LOG.info("badMessage: bad encoding expected ..."); - String response; - - response = _connector.getResponse("GET /foo/bar%c0%00 HTTP/1.1\r\n" + - "Host: localhost\r\n" + - "Connection: close\r\n" + - "\r\n"); - checkContains(response, 0, "HTTP/1.1 400"); - - response = _connector.getResponse("GET /bad/utf8%c1 HTTP/1.1\r\n" + - "Host: localhost\r\n" + - "Connection: close\r\n" + - "\r\n"); - checkContains(response, 0, "HTTP/1.1 200"); //now fallback to iso-8859-1 - } - @Test public void testAutoFlush() throws Exception {