Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception message for request/response header too large #8590

Open
cowwoc opened this issue Sep 15, 2022 · 5 comments
Open

Improve exception message for request/response header too large #8590

cowwoc opened this issue Sep 15, 2022 · 5 comments
Assignees

Comments

@cowwoc
Copy link
Contributor

cowwoc commented Sep 15, 2022

Jetty version(s): 11.0.11

Enhancement Description

When the request or response headers are too large, Jetty throws an exception stating Request header too large or Response header too large.

Is it possible to provide additional information such as: Header size X was greater than HttpClient.requestBufferSize Y.

This helps in two ways:

  1. It gives the user a rough idea of how big the buffer needs to be.
  2. It gives the user a hint of which HttpClient property needs to be modified.
@cowwoc
Copy link
Contributor Author

cowwoc commented Sep 15, 2022

Additionally, it would be useful to view the offending header value. Even seeing a truncated value would help the user establish whether the client or server needs to be modified.

@joakime
Copy link
Contributor

joakime commented Sep 15, 2022

This can be tricky, because on the server side you don't want to reveal any kind of configuration based information in an exception message as those can flow back to the user in various ways.

Traditionally, these are DEBUG logging messages, and improving those is definitely on the table.

@cowwoc
Copy link
Contributor Author

cowwoc commented Sep 16, 2022

DEBUG logs are fine with me.

@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Sep 17, 2023
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Oct 15, 2023
@sbordet sbordet self-assigned this Oct 4, 2024
@sbordet
Copy link
Contributor

sbordet commented Oct 4, 2024

This can be solved as part of #5685.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants