fix empty annotation

[gianrubio]

PR #105 was not filling the default annotation if env LEGO_KUBE_ANNOTATION is empty.

I’m not sure, but looks like the behaviour of LEGO_KUBE_ANNOTATION is the same when you have 2+ kube-lego instances running with different LEGO_DEFAULT_INGRESS_CLASS.

production ingress

apiVersion: v1
items:
- apiVersion: extensions/v1beta1
  kind: Ingress
  metadata:
    annotations:
      ingress.kubernetes.io/ssl-redirect: "false"
      kubernetes.io/ingress.class: production
      kubernetes.io/tls-acme: "true"

staging ingress

apiVersion: v1
items:
- apiVersion: extensions/v1beta1
  kind: Ingress
  metadata:
    annotations:
      ingress.kubernetes.io/ssl-redirect: "false"
      kubernetes.io/ingress.class: staging
      kubernetes.io/tls-acme: "true"

@gurvindersingh WDYT?

[gurvindersingh]

Looking at the code

kube-lego/pkg/ingress/ingress.go

Line 166 in de058f9

func (i *Ingress) Ignore() bool {

, it seems behavior is the same. In our setup all our ingress are of the same class nginx and that's why we needed to have the LEGO_KUBE_ANNOTATION annotation to have different LE provider.

The code here https://github.com/jetstack/kube-lego/blob/master/pkg/kubelego_const/consts.go#L24 saying allowed ingress classes are nginx,gce, so I am not sure how kube-lego works with ingress.class: production/staging.

[gurvindersingh]

Regarding not getting value fron ENV variable, I think that was due to logic typo as proposed fix in #110 @gianrubio can you confirm with #110 in, your patch is not required and kube-lego works as intended.

[gianrubio]

@gurvindersingh I haven't tested #110, but looks like it fix the issue. I'll wait the merge of #110 to close this issue.