Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review wrt AsyncGuidance #229

Open
bartelink opened this issue Aug 16, 2023 · 0 comments
Open

Review wrt AsyncGuidance #229

bartelink opened this issue Aug 16, 2023 · 0 comments

Comments

@bartelink
Copy link
Collaborator

See https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md. Go through with a fine tooth comb verifying all is adhered to, e.g.:

  • TaskCompletionSource management is correct wrt disposal etc
  • CancellationTokenSource.Cancel is called whereever relevant
@bartelink bartelink changed the title Apply AsyncGuidance Review wrt AsyncGuidance Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartelink