Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencyExtractor should consider import 'xxx' statement #8547

Closed
dy93 opened this issue Jun 10, 2019 · 2 comments
Closed

dependencyExtractor should consider import 'xxx' statement #8547

dy93 opened this issue Jun 10, 2019 · 2 comments

Comments

@dy93
Copy link

dy93 commented Jun 10, 2019

🐛 Bug Report

jest's --onlyChanged option does not consider the module in the import 'xxx'; statement as dependencies.
So I can not get the advantage of --onlyChanged or --changedSince

To Reproduce

Consider the following code snippet:

import './dep';

describe('this test depends on "dep"', () => {
  it('but jest does not consider "dep" as dependencies', () => {
    // do something
  })
})

When I modify dep.js, jest --onlyChanged do not detact the change and re-run the test.

Expected behavior

jest --onlyChanged should re-run the test

@SimenB
Copy link
Member

SimenB commented Jul 15, 2019

Fixed in #8670

@SimenB SimenB closed this as completed Jul 15, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants