--watch Now Throws an Error #8088

arb · 2019-03-08T15:05:34Z

🐛 Bug Report

I recently updated jest to 24.3.1 and now running with --watch throws an error and does not start. The error is:

2019-03-08 09:51 node[1373] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
Error: Error watching file for changes: EMFILE
    at _errnoException (util.js:1022:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1359:9)

I do not have watchman installed globally and again, this was working yesterday and now it's not. I feel like it's an issue with the macOS update but I can't confirm. I know installing watchman via brew is a suggested solution but I've never had to do that before and that seems kind of like it's masking a possible issue with jest.

To Reproduce

npx jest --watch

Expected behavior

I expected jest to continue to work correctly as it has before I updated.

Link to repl or repo (highly encouraged)

https://github.com/arb/celebrate/tree/feature-ref this is the branch I'm working with and currently exhibiting the above behavior.

Run `npx envinfo --preset jest`

Paste the results here:

npx: installed 1 in 1.538s

  System:
    OS: macOS 10.14.3
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  Binaries:
    Node: 8.11.1 - ~/.nvm/versions/node/v8.11.1/bin/node
    Yarn: 1.9.4 - ~/.nvm/versions/node/v8.11.1/bin/yarn
    npm: 5.6.0 - ~/.nvm/versions/node/v8.11.1/bin/npm
  npmPackages:
    jest: ^24.3.1 => 24.3.1

The text was updated successfully, but these errors were encountered:

SimenB · 2019-03-08T15:51:49Z

You can probably install watchman to get around this - brew install watchman.

This is probably because we removed the fsevents crawler (#8048). Not sure why the node crawler explodes, tho.

arb · 2019-03-08T15:54:10Z

@SimenB I'd rather not do that. Like I said in the initial issue, that seems to be masking an actual issue with jest. If I install watchman, reproducing the problem becomes harder.

SimenB · 2019-03-08T15:59:50Z

Sure, I was just trying to unblock you

thymikee · 2019-03-08T16:28:29Z

I tried to run it with yarn (so fresh install) and don't see the error – it's probably related to deps update, so please clean it up. However I can see the same message as here: #8084.

thymikee · 2019-03-08T16:30:10Z

Closing as duplicate of #8084

arb · 2019-03-08T16:32:52Z

@thymikee how is this a duplicate of #8084? The error message is completely different and I'm not using the --changedSince flag either.

thymikee · 2019-03-08T16:34:10Z

This is the error I get when running --watch on your repro, feature-ref branch:

 FAIL   test  test/celebrate.test.js
  ● Test suite failed to run

    TypeError: options.changedFiles.has is not a function

FYI --watch and --changedSince share a lot of logic.

arb · 2019-03-08T16:53:26Z

I see. Thank you for the clarification! I didn't get that MUCH more specific error when I'm running locally, but I agree, the root cause seems to be the same as #8084.

SimenB · 2019-03-12T14:42:28Z

Seems this is still an issue for folks

yoshicarroll · 2019-03-12T18:20:27Z

It is, yes. Jest 23 worked fine. As soon as I updated to Jest 24 24.4.0 it started breaking.

arb · 2019-03-13T13:05:16Z

@yoshicarroll what version of macOS are you running? I'm starting to think that is the common thread.

yoshicarroll · 2019-03-13T15:35:17Z

@arb High Sierra 10.13.6

arb · 2019-03-13T18:52:34Z

Interesting, well it's not that then; I'm on 10.14.3.

yoshicarroll · 2019-03-13T20:03:16Z

I don't know anything about Jest internals, but if someone can point me to where to set a breakpoint and collect some info, I have some time to help out.

elkwood · 2019-03-14T23:19:20Z

I was able to alleviate the issue in my project that is experiencing this by configuring the watchPathIgnorePatterns to ["node_modules"]. As expected, this lowered the number of files being watched to something below my system's limit.

https://jestjs.io/docs/en/configuration.html#watchpathignorepatterns-array-string

arb · 2019-03-15T16:11:33Z

Can confirm this workaround gets around the problem. Make sure you specify the value on the project config if you're using multiple projects. I still believe there needs to be a code fix for this as it was working in version 23, but this is a good workaround for the current problem! 👍

yoshicarroll · 2019-03-15T21:41:43Z

This workaround resolves the errors for me as well, thanks @elkwood.
And, like @arb I too believe a code fix should fix the underlying issue.

SimenB · 2019-03-17T10:56:10Z

My guess is that this is caused by #8048. Maybe we can get sane to re-add fsevents seeing as it'll be easier to install in tue future?

brneto · 2019-03-26T01:01:38Z

I had issue I see here using jest and the only way I could fix that was installing watchman.
Here my environment:

System:
    OS: macOS 10.14.3
    CPU: (8) x64 Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz
  Binaries:
    Node: 11.12.0 - /usr/local/bin/node
    Yarn: 1.15.2 - /usr/local/bin/yarn
    npm: 6.7.0 - /usr/local/bin/npm
  npmPackages:
    jest: ^24.5.0 => 24.5.0

If now is necessary we install watchman to run jest, why that information isn't in Jest website (or documentation)? I needed to do a long research till I get here. Including that information into Jest page installation instruction would make jest user's life a lot easier.

Why not just include this information somewhere in Jest website?

BoraALAP · 2019-03-27T15:01:26Z

I'm learning react and I was testing redux actions, I installed es-lint to project (for no reason) and start getting the same error. Deleted node-modules and removed es-lint from the project. Everything went back to normal. I don't think this information helps you at all :), but just wanted to let you know es-lint might be part of the issue as well for you guys too.

gaearon · 2019-04-02T15:14:28Z

This issue is a blocker for next Create React App release, which by itself blocks several important updates (including React Hooks lint rules).

If we can't resolve it on the sane level, can we bring fsevents back into Jest directly?

I'm worried about the path forward here.

SimenB · 2019-04-02T15:18:48Z

I wonder if we can solve this in sane with the next release of fsevents, which won't require building native dependencies (it'll use n-api).

EDIT: We can probably just vendor it for now, we already vendor their watchman implementation (https://github.com/facebook/jest/blob/2bc62803ba457a3139c9533835a6888a824ddf4f/packages/jest-haste-map/src/lib/WatchmanWatcher.js)

EDIT2: pasted wrong link above originally, now fixed

scotthovestadt · 2019-04-02T15:20:42Z

@SimenB why are we watching node_modules by default? I understand doing it when Watchman makes it “free”, but otherwise...? Is there historical context I’m missing?

thymikee · 2019-04-02T15:22:24Z

@scotthovestadt you may ask @cpojer about that, but if we could only watch node_modules by default when watchman is enabled, that would be nice.

scotthovestadt · 2019-04-02T15:24:03Z

Or just a shallow watch of the folder, which would be nice because it would catch new modules. I’ll take a look today.

SimenB · 2019-04-02T15:24:37Z

No idea, maybe @cpojer can chime in. But I guess the point is, since watchman makes it free, they should behave as close as possible? If it's blocking CRA though, they can probably configure Jest to not watch node_modules?

cpojer · 2019-04-02T15:26:31Z

People get upset when we aren't watching node_modules because people tend to change them manually.

elkwood · 2019-04-02T17:55:14Z

I'm not sure that ignoring node_modules will fix the issue for everyone who uses Jest. I can imagine large applications where you still reach the file system's watch limit even if you do ignore node_modules. Probably not the repo I'd want to maintain, but I'm sure they exist.

scotthovestadt · 2019-04-02T17:57:01Z

@elkwood Yeah, going with an alternate solution (see #8258), may revisit defaults on watching node_modules in the future if have more issues in this area.

SimenB · 2019-04-03T05:58:57Z

Fix out in 24.7.0

baixiaoji · 2019-06-04T07:34:08Z

having same error jest@24.8.0, but using 24.7.1 is ok

SimenB · 2019-06-04T08:49:08Z

That's a different error then, please open up a new issue

baixiaoji · 2019-06-04T09:06:58Z

That's a different error then, please open up a new issue

so you already known the error? but I reinstall jest@24.8.0, the error has gone

SimenB · 2019-06-04T09:16:14Z

No, but the error talked about in this issue has been fixed.

normancarcamo · 2019-06-16T00:07:42Z

I confirm that ignoring the node_modules worked again:

{
  "watchPathIgnorePatterns": ["node_modules"]
}

jest@24.8.0 doesn't solve the issue for me :/

jeffbski-rga · 2019-10-31T16:22:17Z

Problem still exists in jest@24.9.0 but configuring watchPathIgnorePatterns to ignore node_modules does fix.

github-actions · 2021-05-11T18:11:55Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

arb added the 🐛 Bug label Mar 8, 2019

thymikee closed this as completed Mar 8, 2019

arb mentioned this issue Mar 11, 2019

fix: serialize changedFiles passed to workers #8090

Merged

yoshicarroll mentioned this issue Mar 11, 2019

Issue with version 24.3.0 using --changedSince flag #8084

Closed

SimenB reopened this Mar 12, 2019

SimenB mentioned this issue Mar 14, 2019

Update to Jest 24 facebook/create-react-app#6278

Merged

iansu mentioned this issue Mar 14, 2019

Update Jest to fix watch bug facebook/create-react-app#6646

Closed

SimenB mentioned this issue Mar 20, 2019

jest --watch does'nt work #8170

Closed

scotthovestadt mentioned this issue Apr 2, 2019

Fix fs watcher EMFILE error. #8258

Merged

scotthovestadt closed this as completed in #8258 Apr 2, 2019

arb mentioned this issue Apr 2, 2019

jest Upgrade arb/celebrate#108

Closed

SimenB mentioned this issue Aug 20, 2019

remove fsevents amasad/sane#130

Merged

ntwb mentioned this issue Dec 29, 2019

Error: Error watching file for changes: EMFILE jest-community/vscode-jest#76

Open

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021

--watch Now Throws an Error #8088

--watch Now Throws an Error #8088

Comments

arb commented Mar 8, 2019

🐛 Bug Report

To Reproduce

Expected behavior

Link to repl or repo (highly encouraged)

Run npx envinfo --preset jest

SimenB commented Mar 8, 2019

arb commented Mar 8, 2019

SimenB commented Mar 8, 2019

thymikee commented Mar 8, 2019

thymikee commented Mar 8, 2019

arb commented Mar 8, 2019

thymikee commented Mar 8, 2019 • edited Loading

arb commented Mar 8, 2019 • edited Loading

SimenB commented Mar 12, 2019

yoshicarroll commented Mar 12, 2019

arb commented Mar 13, 2019

yoshicarroll commented Mar 13, 2019

arb commented Mar 13, 2019

yoshicarroll commented Mar 13, 2019

elkwood commented Mar 14, 2019

arb commented Mar 15, 2019

yoshicarroll commented Mar 15, 2019

SimenB commented Mar 17, 2019

brneto commented Mar 26, 2019

BoraALAP commented Mar 27, 2019

gaearon commented Apr 2, 2019

SimenB commented Apr 2, 2019 • edited Loading

scotthovestadt commented Apr 2, 2019

thymikee commented Apr 2, 2019

scotthovestadt commented Apr 2, 2019

SimenB commented Apr 2, 2019

cpojer commented Apr 2, 2019

elkwood commented Apr 2, 2019

scotthovestadt commented Apr 2, 2019

SimenB commented Apr 3, 2019

baixiaoji commented Jun 4, 2019 • edited Loading

SimenB commented Jun 4, 2019

baixiaoji commented Jun 4, 2019 • edited Loading

SimenB commented Jun 4, 2019

normancarcamo commented Jun 16, 2019

jeffbski-rga commented Oct 31, 2019

github-actions bot commented May 11, 2021

Run `npx envinfo --preset jest`

thymikee commented Mar 8, 2019 •

edited

Loading

arb commented Mar 8, 2019 •

edited

Loading

SimenB commented Apr 2, 2019 •

edited

Loading

baixiaoji commented Jun 4, 2019 •

edited

Loading

baixiaoji commented Jun 4, 2019 •

edited

Loading