Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecationEntries should be injected from jest-validate from jest-config. #5828

Closed
wtgtybhertgeghgtwtg opened this issue Mar 18, 2018 · 5 comments

Comments

@wtgtybhertgeghgtwtg
Copy link
Contributor

Do you want to request a feature or report a bug?
I guess it'd be a feature.

What is the current behavior?
jest-validate requires jest-config to get the deprecationEntries function. This means consumers of jest-validate also have to install all the dependencies of jest-config, such as jest-environment-jsdom.

If the current behavior is a bug, please provide the steps to reproduce and
either a repl.it demo through https://repl.it/languages/jest or a minimal
repository on GitHub that we can yarn install and yarn test.

What is the expected behavior?
jest-validate should contain deprecationEntries.

Please provide your exact Jest configuration

Run npx envinfo --preset jest in your project directory and paste the
results here

@thymikee
Copy link
Collaborator

Ugh, I don't think that's a good idea, because deprecationEntries are Jest-specific and we would still ship some of Jest code to jest-validate consumers.

I agree however that needs to change. We should pass this object as third argument to validateCLIOptions fn, so it's injected by the module it's used in.

@thymikee thymikee changed the title Consider moving deprecationEntries from jest-config to jest-validate. deprecationEntries should be injected from jest-validate from jest-config. Mar 18, 2018
@wtgtybhertgeghgtwtg
Copy link
Contributor Author

wtgtybhertgeghgtwtg commented Apr 3, 2018

This is causing some issues in other whatever. lint-staged/lint-staged#414
Granted, it just triggering an underlying issue.

@SimenB
Copy link
Member

SimenB commented Apr 3, 2018

jest-validate should definitely be able to drop the jest-config dependency. PR very much welcome for this 🙂 I agree with @thymikee that it should be injected as a separate argument instead of living inside jest-validate.

@SimenB
Copy link
Member

SimenB commented Apr 28, 2018

Closed in #6067

@SimenB SimenB closed this as completed Apr 28, 2018
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants